mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ccollins476ad commented on a change in pull request #1030: mempool: Add os_mempool_clear function
Date Tue, 17 Apr 2018 02:00:19 GMT
ccollins476ad commented on a change in pull request #1030: mempool: Add os_mempool_clear function
URL: https://github.com/apache/mynewt-core/pull/1030#discussion_r181933594
 
 

 ##########
 File path: kernel/os/include/os/os_mempool.h
 ##########
 @@ -188,6 +188,15 @@ os_error_t os_mempool_init(struct os_mempool *mp, uint16_t blocks,
 os_error_t os_mempool_ext_init(struct os_mempool_ext *mpe, uint16_t blocks,
                                uint32_t block_size, void *membuf, char *name);
 
+/**
+ * Clears a memory pool.
+ *
+ * @param mp            Pointer to a pointer to a mempool
 
 Review comment:
   Too many levels of indirection in this comment :). How about: "Mempool to clear"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message