mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ut...@apache.org
Subject [mynewt-core] branch master updated: Fix console echo in minimal console
Date Wed, 04 Apr 2018 11:09:45 GMT
This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
     new b11615e  Fix console echo in minimal console
b11615e is described below

commit b11615e137d305cdbdd1b65b73365bdc102d1b52
Author: Fabio Utzig <utzig@apache.org>
AuthorDate: Thu Mar 29 16:28:11 2018 -0300

    Fix console echo in minimal console
    
    console minimal was using `console_echo()` function to set echo, but
    the function was empty on the minimal version.
    
    Signed-off-by: Fabio Utzig <utzig@apache.org>
---
 sys/console/minimal/include/console/console.h | 6 +-----
 sys/console/minimal/src/console.c             | 6 ++++++
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/sys/console/minimal/include/console/console.h b/sys/console/minimal/include/console/console.h
index 4334008..5e8eeb2 100644
--- a/sys/console/minimal/include/console/console.h
+++ b/sys/console/minimal/include/console/console.h
@@ -45,11 +45,7 @@ int console_read(char *str, int cnt, int *newline);
 
 void console_blocking_mode(void);
 void console_non_blocking_mode(void);
-
-static void inline
-console_echo(int on)
-{
-}
+void console_echo(int on);
 
 static int console_printf(const char *fmt, ...)
     __attribute__ ((format (printf, 1, 2)));;
diff --git a/sys/console/minimal/src/console.c b/sys/console/minimal/src/console.c
index 151facc..d0fc786 100644
--- a/sys/console/minimal/src/console.c
+++ b/sys/console/minimal/src/console.c
@@ -64,6 +64,12 @@ console_out(int c)
 }
 
 void
+console_echo(int on)
+{
+    echo = on;
+}
+
+void
 console_write(const char *str, int cnt)
 {
     int i;

-- 
To stop receiving notification emails like this one, please contact
utzig@apache.org.

Mime
View raw message