From commits-return-17457-archive-asf-public=cust-asf.ponee.io@mynewt.apache.org Fri Mar 30 01:16:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1674C180679 for ; Fri, 30 Mar 2018 01:16:26 +0200 (CEST) Received: (qmail 74942 invoked by uid 500); 29 Mar 2018 23:16:26 -0000 Mailing-List: contact commits-help@mynewt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mynewt.apache.org Delivered-To: mailing list commits@mynewt.apache.org Received: (qmail 74910 invoked by uid 99); 29 Mar 2018 23:16:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 23:16:26 +0000 From: GitBox To: commits@mynewt.apache.org Subject: [GitHub] utzig commented on a change in pull request #947: Refactor/easing library Message-ID: <152236538560.22887.8967020432761634017.gitbox@gitbox.apache.org> Date: Thu, 29 Mar 2018 23:16:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit utzig commented on a change in pull request #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178203482 ########## File path: util/easing/src/easing.c ########## @@ -43,12 +43,12 @@ static inline float exponential_out(float step, float max_steps, float max_val) { return (step == max_steps) ? max_val : - max_val - pow(max_val, 1.0 - (float)step/max_steps); + max_val - pow(max_val, 1.0f - (float)step/max_steps); Review comment: Since you are moving everything to `float` you could as well get rid of those `(float)` casts. This one would be the same as `max_val - pow(max_val, 1.0f - step/max_steps)`. This happens across much of the refactoring. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services