mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] utzig commented on a change in pull request #947: Refactor/easing library
Date Thu, 29 Mar 2018 23:16:25 GMT
utzig commented on a change in pull request #947: Refactor/easing library
URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178203482
 
 

 ##########
 File path: util/easing/src/easing.c
 ##########
 @@ -43,12 +43,12 @@ static inline float exponential_out(float step, float max_steps, float
max_val)
 {
 	return (step == max_steps) ?
         max_val :
-        max_val - pow(max_val, 1.0 - (float)step/max_steps);
+        max_val - pow(max_val, 1.0f - (float)step/max_steps);
 
 Review comment:
   Since you are moving everything to `float` you could as well get rid of those `(float)`
casts. This one would be the same as `max_val - pow(max_val, 1.0f - step/max_steps)`. This
happens across much of the refactoring.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message