mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] andrzej-kaczmarek commented on a change in pull request #18: nimble/ll: Portion of fixes for the nimble controller.
Date Wed, 28 Mar 2018 09:44:08 GMT
andrzej-kaczmarek commented on a change in pull request #18: nimble/ll: Portion of fixes for
the nimble controller.
URL: https://github.com/apache/mynewt-nimble/pull/18#discussion_r177693484
 
 

 ##########
 File path: nimble/controller/src/ble_ll_ctrl.c
 ##########
 @@ -689,8 +689,8 @@ ble_ll_ctrl_rx_phy_req(struct ble_ll_conn_sm *connsm, uint8_t *req,
         /* XXX: TODO: if we started another procedure with an instant
          * why are we doing this? Need to look into this.*/
 
-        /* Respond to master's phy update procedure */
-        CONN_F_PEER_PHY_UPDATE(connsm) = 1;
+        /* Let us wait for LL_PHY_UPDATE_IND */
+        ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_PHY_UPDATE);
 
 Review comment:
   seems like this only usually works because current procedure is non-idle when this is called
- only bitmask is set in such case which is what you want. in case if above is executed current
procedure will be set to idle and this will start an actualy phy update procedure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message