mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sjanc commented on a change in pull request #770: nimble/ll: Add support for advertising and scan response data fragmentation
Date Thu, 01 Jan 1970 00:00:00 GMT
sjanc commented on a change in pull request #770: nimble/ll: Add support for advertising and
scan response data fragmentation
URL: https://github.com/apache/mynewt-core/pull/770#discussion_r166212034
 
 

 ##########
 File path: net/nimble/controller/src/ble_ll_adv.c
 ##########
 @@ -1031,41 +1033,191 @@ ble_ll_adv_secondary_tx_start_cb(struct ble_ll_sched_item *sch)
     return BLE_LL_SCHED_STATE_DONE;
 }
 
+static uint8_t
+ble_ll_adv_aux_scannable_pdu_payload_len(struct ble_ll_adv_sm *advsm)
+{
+    uint8_t len;
+
+    /* Flags, AdvA and ADI always */
+    len = BLE_LL_EXT_ADV_HDR_LEN + BLE_LL_EXT_ADV_FLAGS_SIZE +
+          BLE_LL_EXT_ADV_ADVA_SIZE + BLE_LL_EXT_ADV_DATA_INFO_SIZE;
+
+    /* TargetA only for directed */
+    if (advsm->props & BLE_HCI_LE_SET_EXT_ADV_PROP_DIRECTED) {
+        len += BLE_LL_EXT_ADV_TARGETA_SIZE;
+    }
+
+    /* TxPower if configured */
+    if (advsm->props & BLE_HCI_LE_SET_EXT_ADV_PROP_INC_TX_PWR) {
+        len += BLE_LL_EXT_ADV_TX_POWER_SIZE;
+    }
+
+    return len;
+}
+
+static void
+ble_ll_adv_aux_calculate(struct ble_ll_adv_sm *advsm,
+                         struct ble_ll_adv_aux *aux, uint16_t aux_data_offset)
+{
+    static uint16_t rem_aux_data_len;
+    static uint8_t hdr_len;
+    static bool chainable;
 
 Review comment:
   why those are static?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message