mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] andrzej-kaczmarek commented on a change in pull request #686: BLE Host flow control
Date Thu, 01 Jan 1970 00:00:00 GMT
andrzej-kaczmarek commented on a change in pull request #686: BLE Host flow control
URL: https://github.com/apache/mynewt-core/pull/686#discussion_r160410405
 
 

 ##########
 File path: net/nimble/host/syscfg.yml
 ##########
 @@ -372,5 +372,29 @@ syscfg.defs:
             Enable Bluetooth Mesh	
         value: 0
 
+    # Flow control settings.
+    BLE_HS_FLOW_CTRL_ITVL:
+        description: >
+            The interval, in milliseconds, that the host should provide
+            number-of-completed-packets updates to the controller.  Set to 0 to
+            disable flow control.
+        value: 0
 
 Review comment:
   it would be good to suggest some recommended value here as it may not be clear whether
to set this to couple of miliseconds or few seconds. or perhaps just make separate syscfg
to enable feature and set this one to recommended default value. actually separate value for
enabling feature would make ifdefs in code a bit easier to understand - right now it may be
confusing why ble_hs_flow_ctrl_itvl is used in ifdefs for someone who did not read description
of this setting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message