mynewt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccoll...@apache.org
Subject [2/7] incubator-mynewt-core git commit: The stack usage for task1, task2, shell and newtmgr tasks is 204, 196, 632 and 192 dwords respectively. Prior to this change the stack size for these tasks was 128, 128, 384 and 512 words respectively. It was easy
Date Fri, 11 Mar 2016 20:18:18 GMT
The stack usage for task1, task2, shell and newtmgr tasks is 204, 196, 632 and
192 dwords respectively. Prior to this change the stack size for these tasks
was 128, 128, 384 and 512 words respectively. It was easy to induce a segfault
on Linux by executing the "tasks" command at the shell prompt.

Bump up the stack sizes of task1, task2, shell and newtmgr tasks to 1024 dwords.


Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/commit/66bad700
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/tree/66bad700
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/diff/66bad700

Branch: refs/heads/develop
Commit: 66bad700e7fba9b54fa5b232adcfc451a53bed4b
Parents: 06bf5d1
Author: Neel Natu <neel@nahannisys.com>
Authored: Thu Mar 10 22:41:25 2016 -0800
Committer: Christopher Collins <ccollins476ad@gmail.com>
Committed: Fri Mar 11 12:16:13 2016 -0800

----------------------------------------------------------------------
 apps/slinky/src/main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/blob/66bad700/apps/slinky/src/main.c
----------------------------------------------------------------------
diff --git a/apps/slinky/src/main.c b/apps/slinky/src/main.c
index edaad80..4534097 100755
--- a/apps/slinky/src/main.c
+++ b/apps/slinky/src/main.c
@@ -45,24 +45,24 @@ int init_tasks(void);
 
 /* Task 1 */
 #define TASK1_PRIO (1)
-#define TASK1_STACK_SIZE    OS_STACK_ALIGN(128)
+#define TASK1_STACK_SIZE    OS_STACK_ALIGN(1024)
 struct os_task task1;
 os_stack_t stack1[TASK1_STACK_SIZE];
 static volatile int g_task1_loops;
 
 /* Task 2 */
 #define TASK2_PRIO (2)
-#define TASK2_STACK_SIZE    OS_STACK_ALIGN(128)
+#define TASK2_STACK_SIZE    OS_STACK_ALIGN(1024)
 struct os_task task2;
 os_stack_t stack2[TASK2_STACK_SIZE];
 
 #define SHELL_TASK_PRIO (3)
 #define SHELL_MAX_INPUT_LEN     (256)
-#define SHELL_TASK_STACK_SIZE (OS_STACK_ALIGN(384))
+#define SHELL_TASK_STACK_SIZE (OS_STACK_ALIGN(1024))
 os_stack_t shell_stack[SHELL_TASK_STACK_SIZE];
 
 #define NEWTMGR_TASK_PRIO (4)
-#define NEWTMGR_TASK_STACK_SIZE (OS_STACK_ALIGN(512))
+#define NEWTMGR_TASK_STACK_SIZE (OS_STACK_ALIGN(1024))
 os_stack_t newtmgr_stack[NEWTMGR_TASK_STACK_SIZE];
 
 struct log_handler log_console_handler;


Mime
View raw message