Return-Path: X-Original-To: apmail-mynewt-commits-archive@minotaur.apache.org Delivered-To: apmail-mynewt-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50094188A6 for ; Sat, 31 Oct 2015 01:57:51 +0000 (UTC) Received: (qmail 48158 invoked by uid 500); 31 Oct 2015 01:57:51 -0000 Delivered-To: apmail-mynewt-commits-archive@mynewt.apache.org Received: (qmail 48132 invoked by uid 500); 31 Oct 2015 01:57:51 -0000 Mailing-List: contact commits-help@mynewt.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mynewt.incubator.apache.org Delivered-To: mailing list commits@mynewt.incubator.apache.org Received: (qmail 48123 invoked by uid 99); 31 Oct 2015 01:57:51 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2015 01:57:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9442C1A3004 for ; Sat, 31 Oct 2015 01:57:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.77 X-Spam-Level: * X-Spam-Status: No, score=1.77 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id haNGqsiBDmWI for ; Sat, 31 Oct 2015 01:57:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 1517E444C7 for ; Sat, 31 Oct 2015 01:57:49 +0000 (UTC) Received: (qmail 48118 invoked by uid 99); 31 Oct 2015 01:57:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2015 01:57:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 760DBE0498; Sat, 31 Oct 2015 01:57:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ccollins@apache.org To: commits@mynewt.incubator.apache.org Message-Id: <4d35e94bcb494acc9c690daa9fff92cb@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-mynewt-larva git commit: Fix some minor ble spec comments. Date: Sat, 31 Oct 2015 01:57:48 +0000 (UTC) Repository: incubator-mynewt-larva Updated Branches: refs/heads/master d5ed97b0c -> 73f7db240 Fix some minor ble spec comments. Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/commit/73f7db24 Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/tree/73f7db24 Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/diff/73f7db24 Branch: refs/heads/master Commit: 73f7db240a6e96762548648f0183144855d15729 Parents: d5ed97b Author: Christopher Collins Authored: Fri Oct 30 18:57:29 2015 -0700 Committer: Christopher Collins Committed: Fri Oct 30 18:57:29 2015 -0700 ---------------------------------------------------------------------- net/nimble/host/src/host_hci.c | 3 +-- net/nimble/include/nimble/hci_common.h | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/blob/73f7db24/net/nimble/host/src/host_hci.c ---------------------------------------------------------------------- diff --git a/net/nimble/host/src/host_hci.c b/net/nimble/host/src/host_hci.c index 837d2e8..629ea3d 100644 --- a/net/nimble/host/src/host_hci.c +++ b/net/nimble/host/src/host_hci.c @@ -91,8 +91,7 @@ host_hci_cmd_le_set_adv_params(struct hci_adv_params *adv) /* Make sure parameters are valid */ rc = -1; - if ((adv->adv_itvl_min > adv->adv_itvl_max) || - (adv->adv_itvl_min == adv->adv_itvl_max) || + if ((adv->adv_itvl_min >= adv->adv_itvl_max) || (adv->own_addr_type > BLE_HCI_ADV_OWN_ADDR_MAX) || (adv->peer_addr_type > BLE_HCI_ADV_PEER_ADDR_MAX) || (adv->adv_filter_policy > BLE_HCI_ADV_FILT_MAX) || http://git-wip-us.apache.org/repos/asf/incubator-mynewt-larva/blob/73f7db24/net/nimble/include/nimble/hci_common.h ---------------------------------------------------------------------- diff --git a/net/nimble/include/nimble/hci_common.h b/net/nimble/include/nimble/hci_common.h index cff82bd..eebca4c 100644 --- a/net/nimble/include/nimble/hci_common.h +++ b/net/nimble/include/nimble/hci_common.h @@ -21,10 +21,9 @@ /* * HCI Command Header * - * Comprised of the following fields - * -> Opcode command field (1) - * -> Opcode group field (1) - * -> Parameter Length (1) + * Comprises the following fields + * -> Opcode group field & Opcode command field (2) + * -> Parameter Length (1) * Length of all the parameters (does not include any part of the hci * command header */