Mailing-List: contact users-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Discussion" <users@myfaces.apache.org>
Received-SPF: pass (athena.apache.org: domain of wtlucy@us.ibm.com designates
 32.97.110.159 as permitted sender)
In-Reply-To: 
 <CABujnVeU4HkdHGRXfp9pLTRqzhQuU5mmmFGLA+An-dXjhYtF0w@mail.gmail.com>
References: 
 <OFA243D221.EAE2BF56-ON87257D3A.003F4A13-85257D3A.003FC7A5@us.ibm.com>
 <CABujnVeU4HkdHGRXfp9pLTRqzhQuU5mmmFGLA+An-dXjhYtF0w@mail.gmail.com>
Subject: Re: Issue with javax.faces.SEPARATOR_CHAR and commandLink
To: "MyFaces Discussion" <users@myfaces.apache.org>
Message-ID: 
 <OF82435DBD.C309BAA7-ON87257D3A.00630AC6-85257D3A.00636A43@us.ibm.com>
From: William Lucy <wtlucy@us.ibm.com>
Date: Wed, 20 Aug 2014 14:05:48 -0400
MIME-Version: 1.0
Content-type: multipart/alternative;
	Boundary="0__=08BBF7A9DFF08C568f9e8a93df938690918c08BBF7A9DFF08C56"
Content-Disposition: inline

--0__=08BBF7A9DFF08C568f9e8a93df938690918c08BBF7A9DFF08C56
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: quoted-printable


Hi Leonardo,

Thanks for the feedback.  I've tested your suggestion, and that seems t=
o
work fine.  JIRA issue opened at:
https://issues.apache.org/jira/browse/MYFACES-3919

Regards,
Bill

Leonardo Uribe <lu4242@gmail.com> wrote on 08/20/2014 01:14:39 PM:

> From: Leonardo Uribe <lu4242@gmail.com>
> To: MyFaces Discussion <users@myfaces.apache.org>
> Date: 08/20/2014 01:15 PM
> Subject: Re: Issue with javax.faces.SEPARATOR_CHAR and commandLink
>
> Hi
>
> 2014-08-20 6:36 GMT-05:00 William Lucy <wtlucy@us.ibm.com>:
> >
> >
> > Hello all,
> >
> > We've come across an issue while trying to modify the
> > javax.faces.SEPARATOR_CHAR - changing it to a non-colon character s=
eems
to
> > break h:commandLink actions.  For example, with the separator chara=
cter
set
> > to a hyphen "-", the following navigation does not work (the output=

link
> > just triggers a refresh):
> >
> > <f:view>
> > <h:form>
> >         <h:commandLink id=3D"link" action=3D"toLink.html">
> >                 <h:outputText value=3D"Link" />
> >         </h:commandLink>
> > </h:form>
> > </f:view>
> >
> > This can be observed in MyFaces 2.0.21, 2.1.15, and 2.2.4.  A
workaround is
> > to enable the context parameter
> > org.apache.myfaces.RENDER_FORM_SUBMIT_SCRIPT_INLINE, however that
parameter
> > has been removed in the 2.2 branch.  (It's also not a particularly
> > desirable workaround.)
>
> Yes, that's the reason why we remove it. It was legacy stuff from 1.1=
/1.2
and
> with 2.2 it is the right time to do a cleanup in the codebase.
>
> >  The issue here seems to stem from the oamSubmit.js
> > script; in that file there is a call
> >
> >     myfaces.oam.setHiddenInput(formName, formName + ':' + '_idcl',
linkId);
> >
> > which explicitly passes uses a colon separator character.  In
> > HtmlRendendererUtils.getHiddenCommandLinkFieldname, however, we hav=
e
> >
> >     return formInfo.getFormName() + UINamingContainer.getSeparatorC=
har
> > (FacesContext.getCurrentInstance())+ HIDDEN_COMMANDLINK_FIELD_NAME;=

> >
> > which will cause the wrong hidden field name to be searched, and th=
e
broken
> > actions seen here.
> >
> > Is this a bug, or just an accepted limitation of
javax.faces.SEPARATOR_CHAR
> > use?  Thanks for any feedback!
> >
>
> It is a bug. We should not use UINamingContainer.getSeparatorChar(...=
) to
> render that hidden field and enforce ':' instead. The reason is the
intention
> of use javax.faces.SEPARATOR_CHAR is to avoid the collision with css
> when you use the ':', but in this case the intention is to create a
hidden
> field, with no real underlying component, so it is better to let ':'o=
n
the js
> file. Please create an issue in MyFaces issue tracker and I'll fix it=
 on
all
> affected branches.
>
> https://issues.apache.org/jira/browse/MYFACES
>
> regards,
>
> Leonardo Uribe
>
> > Bill Lucy
> > IBM RTP WebSphere
> > wtlucy@us.ibm.com
>=

--0__=08BBF7A9DFF08C568f9e8a93df938690918c08BBF7A9DFF08C56--