Mailing-List: contact users-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Discussion" <users@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of buettner.marcus@gmail.com
 designates 209.85.210.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CABujnVf_Ojd+XLu0Rk7LTSbNwuL039gLD2VTZMk2_1B+Wwy15g@mail.gmail.com>
References: 
 <CALL3D564EYC+qfRvhF6m8VK1ao-++FeGFGgdrDJUnuS36N8hbg@mail.gmail.com>
	<CABujnVdv=JJja=djo-dKdBPmrA-xPJzDDy_YnNAS7Y59N5=+Aw@mail.gmail.com>
	<1334599666.1377.YahooMailNeo@web171502.mail.ir2.yahoo.com>
	<CABujnVf_Ojd+XLu0Rk7LTSbNwuL039gLD2VTZMk2_1B+Wwy15g@mail.gmail.com>
Date: Tue, 17 Apr 2012 09:39:40 +0200
Message-ID: 
 <CALL3D54JgLFVtWB45ePNAiVkbdKAhGokAE5kcOHPtjrzHtia8A@mail.gmail.com>
Subject: Re: Ajax update of a composite component within ui:repeat doesn't
 work
From: =?ISO-8859-1?Q?Marcus_B=FCttner?= <buettner.marcus@gmail.com>
To: MyFaces Discussion <users@myfaces.apache.org>
Content-Type: multipart/alternative; boundary=90e6ba6e8b34a58d7704bddb0a3e

--90e6ba6e8b34a58d7704bddb0a3e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thx Leonardo!

I've patched your fix locally an it works. But I think you mean line 728
instead of 714.

I created an Issue:
https://issues.apache.org/jira/browse/MYFACES-3527

Regards,
Buett

2012/4/16 Leonardo Uribe <lu4242@gmail.com>

> Hi
>
> It seems there is a bug inside _setRowIndex() line 714:
>
> _initialDescendantComponentState =3D saveDescendantComponentStates(this,
> false, false);
>
> should be
>
> _initialDescendantComponentState =3D saveDescendantComponentStates(this,
> true, true);
>
> Since all content of a composite component is inside a facet, the
> state for that facet is not saved and it should be.
>
> A fast workaround is wrap all content of ui:repeat inside a
> h:panelGroup. (not tested yet). Please create the issue and I'll fix
> it.
>
> regards,
>
> Leonardo Uribe
>
> 2012/4/16 Mark Struberg <struberg@yahoo.de>:
> > Hi Leo!
> >
> > Did you also try the stuff with composite components inside ui:repeat?
> >
> > Default components seem to work, but composite components are probably
> broken.
> >
> >
> > Buett will upload a sample code later today.
> >
> > LieGrue,
> > strub
> >
> >
> > ----- Original Message -----
> >> From: Leonardo Uribe <lu4242@gmail.com>
> >> To: MyFaces Discussion <users@myfaces.apache.org>
> >> Cc:
> >> Sent: Monday, April 16, 2012 6:32 PM
> >> Subject: Re: Ajax update of a composite component within ui:repeat
> doesn't work
> >>
> >> Hi
> >>
> >> There was two issues solved in 2.1.7 related to ui:repeat:
> >>
> >> https://issues.apache.org/jira/browse/MYFACES-3415
> >>
> >> [ui:repeat] field value disappears if validation error exists on
> current site
> >>
> >> https://issues.apache.org/jira/browse/MYFACES-3463
> >>
> >> Refactor UIRepeat code to implement PSS algorithm like UIData and fix
> >> state behavior
> >>
> >> The code taken from UIData has been already tested and there are some
> >> junit tests for ui:repeat, so in theory it should work.
> >>
> >> regards,
> >>
> >> Leonardo Uribe
> >>
> >> 2012/4/16 Marcus B=FCttner <buettner.marcus@gmail.com>:
> >>>  Hi,
> >>>
> >>>  This following example works with MyFaces 2.1.6 but not with 2.1.7.
> >>>
> >>>  mycc.xhtml:
> >>>  <cc:interface>
> >>>     <cc:attribute name=3D"state"
> >> type=3D"ExampleModel.State"/>
> >>>  </cc:interface>
> >>>
> >>>  <cc:implementation>
> >>>     <h:selectBooleanCheckbox
> >> value=3D"#{cc.attrs.state.state}">
> >>>         <f:ajax execute=3D"@this" render=3D"@form"/>
> >>>     </h:selectBooleanCheckbox>
> >>>     <h:outputText value=3D"State: #{cc.attrs.state.state}"/>
> >>>  </cc:implementation>
> >>>
> >>>
> >>>  example.xhtml:
> >>>  <h:form id=3D"form">
> >>>     <ui:repeat value=3D"#{example.states}"
> >> var=3D"state">
> >>>         <my:mycc state=3D"#{state}"/>
> >>>     </ui:repeat>
> >>>     <my:mycc state=3D"#{example.state}"/>
> >>>  </h:form>
> >>>
> >>>  In debugger I saw the submitted value of the checkbox is set but thi=
s
> state
> >>>  is overridden a little bit later by
> >>>  UIRepeate#restoreDescendantComponentStates method which is triggered
> by
> >>>  UIRepeat#setIndex which is called by UIRepeat#visitTree.
> >>>
> >>>  Any ideas?
> >>>
> >>>  Regards,
> >>>  Marcus
> >>
>

--90e6ba6e8b34a58d7704bddb0a3e--