myfaces-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Wessendorf" <mat...@apache.org>
Subject Re: SOLVED - Re: Re: Re: [Skinning] tree/table issues (was Re: Re: Re: [Trinidad] your thoughts on a 1.2.3 rc)
Date Thu, 18 Oct 2007 15:16:01 GMT
ok,

this made my day.
I'll provide the bits for the RC on Monday.

-M

On 10/18/07, wolfgang.toepfer@pta.de <wolfgang.toepfer@pta.de> wrote:
>
>
> Hi,
>
> Sorry it's all fine now. The reason was an error in the CSS: there was an
> illegal  // out comment somewhere in the CSS file which corrupted the whole
> skinning..
> Even the panelPopup issue is gone :-)
>
> Thanks,
> Wolfgang.
>
>
>
>  *wolfgang.toepfer@pta.de*
>
> 18.10.2007 14:06  Bitte antworten an
> "MyFaces Discussion" <users@myfaces.apache.org>
>
>   An
> "MyFaces Discussion" <users@myfaces.apache.org>  Kopie
>
>  Thema
> Re: Re: [Skinning] tree/table issues (was Re: Re: Re: [Trinidad] your
> thoughts on a 1.2.3 rc)
>
>
>
>
>
>
>
> The tr:table with selection mode single and the tr:tree with entirely
> disclosed rowKeys have deteriorated regarding
> the out-of-the-box skin.
>
> For instance, the root of the tr:tree is shown with an underscored gif,
> very strange. The colour is set to stark blue
> and the font seems something like Courier..
>
> Regarding the tr:table the changing row-colouring, which is set to
> alternate from row to row, you now only see
> the naked date lines without any style addition.
>
>
>
>   *"Matthias Wessendorf" <matzew@apache.org>*
> Gesendet von: mwessendorf@gmail.com
>
> 18.10.2007 12:57
>   Bitte antworten an
> "MyFaces Discussion" <users@myfaces.apache.org>
>
>   An
> "MyFaces Discussion" <users@myfaces.apache.org>  Kopie
>
>  Thema
> Re: [Skinning] tree/table issues (was Re: Re: Re: [Trinidad] your thoughts
> on a 1.2.3 rc)
>
>
>
>
>
>
>
>
> I remember that there was a discussion on a change, related to
> skinning of tree / treeTable.
>
> But, looks like that Wolfgang has an issue with "tree" and "table"
> after updating to 1.2.3.
>
> -M
>
> On 10/18/07, Cristi Toth <cristi.toth@gmail.com> wrote:
> > Hi Matthias,
> >
> > I discussed on the mailling list with Jeanne W. and Martin M. about the
> > skinning of the tree and treeTable
> > and I refactored and improved them (a lot I might say)
> > I created an issue TRINIDAD-769 and submitted a patch with the
> > modifications.
> > I worked on 1.0.4 snapshot, but I believe they'll work just fine on
> 1.2.*
> > too.
> >
> > Can you please check the patch and maybe submit it if ok?
> > I added skin-selector docs, default skin entries and I added a tree in
> the
> > skins demo.
> >
> > There are also some old p_Ora... skin selectors for the tree that might
> be
> > not used anymore,
> > I could refactor them also, but I thought in a separate patch.
> >
> > regards,
> >
> >
> >
> >  On 10/18/07, Matthias Wessendorf <matzew@apache.org> wrote:
> > > Eh,
> > >
> > > that sounds bad.
> > > Can you confirm that by some more info ?
> > >
> > > Was there any commit that broke it ?
> > >
> > > Thx,
> > > Matthias
> > >
> > > On 10/18/07, wolfgang.toepfer@pta.de <wolfgang.toepfer@pta.de> wrote:
> > > >
> > > > Hi,
> > > >
> > > > Another problem with 1.2.3 SNAPSHOT (10/12/07) seems to be that the
> > skinnings of various components
> > > > are gone e.g. the trees and tables.
> > > >
> > > > It is not a matter of any skinnig setup in the CSS file, it is the
> basic
> > skinning that comes out-of-the-box which
> > > > has magically disappeared now :-(
> > > >
> > > > I noticed this quite late because of not restarting the application
> > server often enough.. ;)
> > > >
> > > > I think this should be made sure it is fixed. Otherwise, believe it,
> the
> > whole 1.2.3 would look pretty poor!
> > > >
> > > > Best wishes,
> > > > Wolfgang.
> > > >
> > > >
> > > >
> > > >
> > > >  wolfgang.toepfer@pta.de
> > > >
> > > > 17.10.2007 09:55
> > > >
> > > > Bitte antworten an
> > > >  "MyFaces Discussion" <users@myfaces.apache.org>
> > > >
> > > >
> > > > An "MyFaces Discussion" < users@myfaces.apache.org>
> > > >
> > > > Kopie
> > > >
> > > >
> > > > Thema Re: Re: [Trinidad] your thoughts on a 1.2.3 rc
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >  Hi,
> > > >
> > > >  Not so sure if it's really there or, even, if the fixes really
> relate
> > to FF 2.
> > > >
> > > >  Our snapshot is from last Friday,  10/12/07. The last svn entry I
> saw
> > from below svn link is from 7th of October.
> > > >  I tested panelPopup on FF 2 with the 1.2.3 SNAPSHOT just a few
> moments
> > ago and
> > > >  it completely blocks the whole FF window including the panelPopup,
> see
> > below(est) mail.
> > > >
> > > >  Best wishes,
> > > >  Wolfgang.
> > > >
> > > >
> > > >
> > > >  "Andrew Robinson" <andrew.rw.robinson@gmail.com>
> > > >
> > > > 16.10.2007 20:57
> > > >
> > > >
> > > > Bitte antworten an
> > > >  "MyFaces Discussion" <users@myfaces.apache.org>
> > > >
> > > >
> > > >
> > > > An "MyFaces Discussion" < users@myfaces.apache.org>
> > > >
> > > > Kopie
> > > >
> > > >
> > > > Thema Re: [Trinidad] your thoughts on a 1.2.3 rc
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >  AFAICT the file does have the 1.0.3 changes
> > > >
> > > >  File:
> > > >
> >
> http://svn.apache.org/viewvc/myfaces/trinidad/branches/1.2.3-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/PanelPopup.js
> > > >
> > > >  On 10/16/07, wolfgang.toepfer@pta.de < wolfgang.toepfer@pta.de >
> wrote:
> > > >
> > > >  Hi,
> > > >
> > > >  The only issue that I noticed which is important to have fixed in
> the
> > 1.2.3 rc ( at least for our project ;)
> > > >  is the panelPopup with modal=true in FF2. AFAIK it is fixed in
> 1.0.3,
> > according to below attached mail,
> > > >  and so I assume it will also be in 1.2.3 hopefully :-)
> > > >
> > > >  We have been working with a 1.2.3. SNAPSHOT for a while and it
> seemed
> > rather stable to us.
> > > >  So I would vote for a go at 1.2.3rc (again, provided above fix is
> > contained ;)
> > > >
> > > >  Best wishes,
> > > >  Wolfgang.
> > > >
> > > >  On 10/16/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > >  hi,
> > > >
> > > >  I am still behind my mails, but noticed that a 1.2.3-branch has
> been
> > > >  created. I'd like to ask for a timeframe for when we can try to
> > > >  release a 1.2.3, based on this branch.
> > > >
> > > >  Are there any (big) know issues?
> > > >  Did someone used it for testing already?
> > > >
> > > >  Thx,
> > > >  Matthias
> > > >
> > > >  ----- Weitergeleitet von Wolfgang Toepfer/PTA_GL/De am 16.10.200715:01
> > -----
> > > >  "Andrew Robinson" < andrew.rw.robinson@gmail.com>
> > > >
> > > > 11.10.2007 18:08
> > > >
> > > >
> > > > Bitte antworten an
> > > >  "MyFaces Discussion" < users@myfaces.apache.org >
> > > >
> > > >
> > > >
> > > > An "MyFaces Discussion" <users@myfaces.apache.org >
> > > >
> > > > Kopie
> > > >
> > > >
> > > > Thema Re: [Trinidad] tr:panelPopup broken in Trinidad 1.2.2 with FF
> 2.x
> > ?
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >  1.2.3 will have some large position fixes. 1.0.3 already has them.
> > > >
> > > >  On 10/11/07, wolfgang.toepfer@pta.de < wolfgang.toepfer@pta.de>
> wrote:
> > > >  >
> > > >  > Hi,
> > > >  >
> > > >  > For your information, as I am not sure wether this is a known
> problem
> > > >  > or just a configuration issue on my side.
> > > >  >
> > > >  >  I tried a simple popup such as
> > > >  >
> > > >  > <tr:panelPopup text="Auftragsselektion!" title="Gefundene
> Auftraege"
> > > >  > alignment="center" modal="true">
> > > >  >
> > > >  >                 <tr:outputText value="Do you want to finish?"
/>
> > > >  >
> > > >  >
> > > >  >
> > > >  >                                  <trh:rowLayout>
> > > >  >
> > > >  > <tr:commandButton accessKey="1" text="1:Cancel"
> > > >  >
> > > >  > action="fXAbbrechen"/>
> > > >  >
> > > >  > <tr:commandButton accessKey="2" text="2:Ok"
> > > >  >
> > > >  > action="f1Change"/>
> > > >  >                                    </trh:rowLayout>
> > > >  >
> > > >  >  </tr:panelPopup>
> > > >  >
> > > >  > However, this only works in IE 7 but not in FF 2.x. In FF the
> > behaviour is
> > > >  > strangely buggy: the mouse pointer
> > > >  > switches to a "prohibited" symbol and everything is disabled
> apart
> > from FF's
> > > >  > close button. BTW there is no
> > > >  > Javascript error.
> > > >  >
> > > >  > Any ideas regarding this behaviour?
> > > >  >
> > > >  > Thanks,
> > > >  > Wolfgang.
> > > >  >
> > > >  >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
> >
> > --
> > Cristi Toth
> >
> > -------------
> > Codebeat
> > www.codebeat.ro
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
>


-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org

Mime
View raw message