myfaces-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Cooper" <matt.fa...@gmail.com>
Subject Re: [Trinidad] Skinnning dev guide now available!
Date Wed, 22 Aug 2007 21:03:55 GMT
Hi Jeanne,

To folks that are not CSS and skinning experts, it is not always clear what
this means:

"[-tr-inhibit] is used to inhibit/reset css properties that you are
inheriting from a base skin"

I've seen someone use:

af|panelGroupLayout {
  font-size: 18pt;
}
af|commandButton {
  -tr-inhibit: font-size;
}

<tr:panelGroupLayout>
  <tr:commandButton text="Hello"/>
</tr:panelGroupLayout>

and expect the button's font size to be the browser default, thinking that
since it inherits the font-size from the panelGroupLayout, putting the
inhibit statement in the commandButton will take care of it.

Also it isn't clear what will happen if the skins look like this:

/* definitions in the base skin */
af|commandButton.foo {
  font-size: 18pt;
}
.bar af|commandButton {
  font-size: 24pt;
}

/* definition in the extended skin */
af|commandButton {
  -tr-inhibit: font-size;
}

I think the docs explain the differences between "padding" and
"padding-right" clearly but perhaps the inheriting aspect of what gets
inhibited could be clearer.

I was thinking that the docs should say something along the lines of this:
"The inhibitions are server-side only, any styles that get applied based on
cascading rules in the browser will not be inhibited."
However, if examples are easier to understand (as seen above), then let's
put them in.

Thanks,
Matt

On 8/22/07, Jeanne Waldman <jeanne.waldman@oracle.com> wrote:
>
>  Hi Matt,
> Can you elaborate so I'm sure what you are saying?
> Thanks,
> Jeanne
>
> Matt Cooper wrote:
>
> Hi Jeanne,
>
> This looks great!
>
> Do you think we need to call out that *-tr-inhibit* will only perform
> server-side inhibiting; it will not inhibit styles that resolve in the
> browser bases on things like selector specificity.
>
> Thank you,
> Matt
>
> On 8/22/07, Jeanne Waldman <jeanne.waldman@oracle.com> wrote:
> >
> > Hi there,
> >
> > I finally took some time to put together a skinning dev guide. This is
> > the first draft. I'll give myself
> > a break from looking at it and then proofread it, unless anyone else
> > wants to. :) Feel free to give suggestions
> > on new sections or sections that are confusing. You can create a JIRA
> > issue if you want.
> >
> > The link is:
> > http://myfaces.apache.org/trinidad/devguide/skinning.html
> >
> > I just noticed that I didn't link to it from the devguide's index page.
> > I'll look into doing that right now.
> >
> > - Jeanne
> >
> >
> >
>

Mime
View raw message