myfaces-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer" <awi...@gmail.com>
Subject Re: [Trinidad] Upgrading to 1.0.2
Date Sat, 25 Aug 2007 01:13:40 GMT
FWIW, in Tomcat 5.0, the PPR code has no issues
stripping the doctype.  Pretty sure it works in OC4J
too.  Going to test Glassfish now.

-- Adam



On 8/23/07, Adam Winer <awiner@gmail.com> wrote:
> trh:head doesn't output the doctype - it's trh:html and/or
> tr:document.
>
> I don't think it's that the PPR code is stripping only 1 doctype.
> I think it's that the two doctypes are written out through different
> mechanisms (ResponseWriter or straight to the serlvet response),
> and PPR is for some reason only catching one of them.
> I'd need to test this out to see exactly what's happening.
>
> -- Adam
>
>
>
> On 8/23/07, Perkins, Nate-P63196 <Nate.Perkins@gdc4s.com> wrote:
> > Adam,
> >
> > I've noticed that the combination of the trh:head tag (which outputs a
> > doctype) and my jsp:output (which also outputs a doctype), creates 2
> > doctypes in the response.  Firefox strips out the 2nd doctype but IE
> > does not.  So perhaps the PPR code is stripping out only 1 of the
> > doctypes?
> >
> >
> > Nate Perkins
> > 480-441-3667
> > nate.perkins@gdc4s.com
> >
> > >This email message is for the sole use of the intended recipient(s) and
> > may contain GDC4S
> > > confidential or privileged information. Any unauthorized review, use,
> > disclosure or distribution
> > > is prohibited. If you are not an intended recipient, please contact
> > the sender by reply email and
> > > destroy all copies of the original message.
> > >
> >
> > -----Original Message-----
> > From: Adam Winer [mailto:awiner@gmail.com]
> > Sent: Wednesday, August 22, 2007 10:57 PM
> > To: MyFaces Discussion
> > Subject: Re: [Trinidad] Upgrading to 1.0.2
> >
> > If you remove the doctype-root-element, doctype-system,
> > and doctype-public off of jsp:output, does the problem
> > go away?  It looks as though that doctype is getting
> > pushed straight into the content stream.  There's code
> > in Trinidad to trim out the doctype (XmlHttpServletResponse
> > and XmlOutput) during an XMLHttp request - don't know
> > why it's not functioning here.
> >
> > -- Adam
> >
> >
> > On 8/22/07, Perkins, Nate-P63196 <Nate.Perkins@gdc4s.com> wrote:
> > > Ok,
> > >
> > > Here's the simplest example I could muster, this results in the same
> > > problem.  I am deploying to JBoss-4.0.5 using Trinidad 1.0.2 and using
> > > the RI 1.1
> > >
> > > Test.jspx:
> > >
> > > <?xml version="1.0" encoding="UTF-8"?>
> > > <jsp:root
> > >         xmlns:jsp="http://java.sun.com/JSP/Page"
> > >         version="2.0"
> > >         xmlns:f="http://java.sun.com/jsf/core"
> > >         xmlns:trh="http://myfaces.apache.org/trinidad/html"
> > >         xmlns:tr="http://myfaces.apache.org/trinidad"
> > >         xmlns:h="http://java.sun.com/jsf/html">
> > >         <f:view>
> > >                 <trh:html>
> > >                 <jsp:output
> > >                         omit-xml-declaration="false"
> > >                         doctype-root-element="html"
> > >
> > > doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"
> > >                         doctype-public="-//W3C//DTD XHTML 1.0
> > > Strict//EN" />
> > >                 <jsp:scriptlet>
> > >         response.addHeader("pragma", "no-store,no-cache");
> > >         response.setHeader("cache-control", "no-cache, no-store, must
> > > re-validate,max-age=-1");
> > >         response.addHeader("cache-control", "pre-check=0,
> > > post-check=0");
> > >         response.setDateHeader("expires", 0);
> > >       </jsp:scriptlet>
> > >                 <jsp:directive.page
> > > contentType="text/html;charset=UTF-8" />
> > >                 <trh:head title="Trinidad 1.0.2 PPR Test">
> > >                         <meta
> > >                                 http-equiv="Content-Type"
> > >                                 content="text/html; charset=UTF-8" />
> > >                         <t:stylesheet
> > > path="#{NMSPanelPageUtil.cssLocation}" />
> > >                 </trh:head>
> > >                 <trh:body>
> > >                         <tr:form id="theForm">
> > >                                 <tr:panelPage>
> > >                                         <!--<jsp:directive.include
> > > file="/menu.jspx" />-->
> > >                                         <tr:panelHeader text="Partial
> > > Submit Test">
> > >                                                 <tr:inputText
> > >                                                         id="input"
> > >
> > > value="#{testBB.input}"
> > >                                                         label="Input:"
> > >
> > > partialTriggers="partialTestButton" />
> > >                                                 <tr:commandButton
> > >
> > > id="partialTestButton"
> > >                                                         text="PPR
> > Test"
> > >
> > > action="#{testBB.action}"
> > >
> > > partialSubmit="true" />
> > >                                                 <tr:outputText
> > >
> > > id="partialOutput"
> > >
> > > value="#{testBB.output}"
> > >
> > > partialTriggers="partialTestButton" />
> > >                                                 <tr:commandButton
> > >
> > > id="fullTestButton"
> > >                                                         text="Full
> > > Submission Test"
> > >
> > > action="#{testBB.action}"/>
> > >                                                 <tr:outputText
> > >
> > id="fullOutput"
> > >
> > > value="#{testBB.output}"/>
> > >                                         </tr:panelHeader>
> > >                                 </tr:panelPage>
> > >                         </tr:form>
> > >                 </trh:body>
> > >                 </trh:html>
> > >         </f:view>
> > > </jsp:root>
> > >
> > > Backing Bean:
> > > import org.apache.myfaces.trinidad.context.RequestContext;
> > >
> > > public class TestBb
> > > {
> > >    private RequestContext rc = RequestContext.getCurrentInstance();
> > >
> > >    public TestBb()
> > >    {
> > >       setOutput("output");
> > >       setInput("input");
> > >    }
> > >
> > >    public void action()
> > >    {
> > >       setOutput(getInput());
> > >    }
> > >
> > >    public String getOutput()
> > >    {
> > >       return (String) rc.getPageFlowScope().get("output");
> > >    }
> > >
> > >    public void setOutput(String output)
> > >    {
> > >       rc.getPageFlowScope().put("output", output);
> > >    }
> > >
> > >    public String getInput()
> > >    {
> > >       return (String) rc.getPageFlowScope().get("input");
> > >    }
> > >
> > >    public void setInput(String input)
> > >    {
> > >       rc.getPageFlowScope().put("input", input);
> > >    }
> > > }
> > >
> > >
> > > Nate Perkins
> > > 480-441-3667
> > > nate.perkins@gdc4s.com
> > >
> > > >This email message is for the sole use of the intended recipient(s)
> > and
> > > may contain GDC4S
> > > > confidential or privileged information. Any unauthorized review,
> > use,
> > > disclosure or distribution
> > > > is prohibited. If you are not an intended recipient, please contact
> > > the sender by reply email and
> > > > destroy all copies of the original message.
> > > >
> > >
> > > -----Original Message-----
> > > From: Adam Winer [mailto:awiner@gmail.com]
> > > Sent: Wednesday, August 22, 2007 1:35 PM
> > > To: MyFaces Discussion
> > > Subject: Re: [Trinidad] Upgrading to 1.0.2
> > >
> > > On 8/22/07, Perkins, Nate-P63196 <Nate.Perkins@gdc4s.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > I'm testing my project with 1.0.2 and I am having several issues.
> > > >
> > > > 1. No PPR activity works, I get a javascript error "Invalid PPR
> > > response"
> > > > any time I try to submit a PPR action
> > >
> > > PPR's been overhauled.  But also tested quite a lot.  I could
> > > really use a testcase.
> > >
> > > > Can anyone give me a clue as to what's wrong and how to fix it?
> > >
> > > Could you use Firebug and look at the responses you're getting
> > > from the server?
> > >
> > > > 2. My skin no longer works, it seems that a few of the selectors
> > have
> > > > changed, namely:
> > > >         a) the panelHeader is rendering with af_messages_header
> > class
> > > >         b) the panelBox has lost its background, it seems like there
> > > is no
> > > > longer a distinction between panelBox transparent, light, etc.
> > >
> > > I think there was a fix just after 1.0.2 that affected panelBox, and
> > > perhaps panelHeader as well.  Deleting af:messages works around
> > > it (with the obvious harm), or moving af:messages to the bottom
> > > of the page.  It's fixed in the 1.0.3 nightlies.
> > >
> > > -- Adam
> > >
> > > >
> > > > I looked at the JIRA issues attached to the 1.0.2 release and did
> > not
> > > see an
> > > > obvious item that applied to either of these discoveries....can
> > anyone
> > > verify
> > > > exactly what it was that changed for each of these?
> > > >
> > > > Nate Perkins
> > > > 480-441-3667
> > > > nate.perkins@gdc4s.com
> > > >
> > > > This email message is for the sole use of the intended recipient(s)
> > > and may
> > > > contain GDC4S
> > > >  confidential or privileged information. Any unauthorized review,
> > use,
> > > > disclosure or distribution
> > > >  is prohibited. If you are not an intended recipient, please contact
> > > the
> > > > sender by reply email and
> > > >  destroy all copies of the original message.
> > > >
> > >
> >
>

Mime
View raw message