myfaces-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Marinschek" <martin.marinsc...@gmail.com>
Subject Re: MYFACES-703 (Have to manually specify renderer type for ExtendedDataTable)
Date Mon, 27 Feb 2006 09:09:56 GMT
Ok, I see.

this code has been fixed by me at this time - this is why I closed the bug.

So you are unhappy cause the bug was introduced first, right?

regards,

Martin

On 2/26/06, Enrique Medina <e.medina.m@gmail.com> wrote:
> Hi Martin,
>
> It's quite simple. If you use the tag, when the doStartTag() method is
> called, also the findComponent() method is, and within this one, the
> setProperties() method is also called. Inside this last method we find this
> code snip:
>
>         if (getRendererType() != null)
>         {
>
> _componentInstance.setRendererType(getRendererType());
>         }
>
> So if you use the ExtendedDataTable through the HtmlDataTableTag, you will
> get:
>
>     public String getRendererType()
>     {
>         return "org.apache.myfaces.Table";
>     }
>
> However, if you create the component dynamically, without the tag, then the
> default renderer type, " javax.faces.Table" is used, and you have to set it
> manually. This was not happening in prior releases to 1.1.1.
>
> Regards,
> Enrique Medina.
>
>
> 2006/2/26, Martin Marinschek < martin.marinschek@gmail.com>:
> > Hi Enrique,
> >
> > hmm.. I thought I had identified the bug being that the renderer-type
> > was not set in the constructor itself. AFAIK, it is not necessary to
> > set the component-extension part in the faces-config.xml.
> >
> > Thoughts?
> >
> > regards,
> >
> > Martin
> >
> > On 2/25/06, Enrique Medina <e.medina.m@gmail.com> wrote:
> > > Gary,
> > >
> > > I don't mind your irony, but as I comment this was a bug closed with
> status
> > > = CANNOT REPRODUCE, although the comment by Darren Jensen provided a
> clear
> > > diagnostic of the problem and the way to solve it rapidly.
> > >
> > > I've been using Myfaces since its very first release, so I know the hard
> > > work these guys are doing, but I've been frustrated by a simple-to-solve
> bug
> > > that was not really solved. If you understand this, you will see that
> this
> > > is not a matter of submitting a patch or not, but a matter of taking
> care of
> > > this type of things (which seem not to be so important for you, but
> maybe
> > > they are for Myfaces beginners, making them leave this great technology
> in
> > > the worst case).
> > >
> > > Anyway, I'll be delighted to continue contributing to the Myfaces
> project,
> > > as I've done until now ;-)
> > >
> > > Regards,
> > > Enrique Medina.
> > >
> > > 2006/2/25, Gary VanMatre < gvanmatre@comcast.net>:
> > > >
> > > > >From: "Enrique Medina" < e.medina.m@gmail.com>
> > > > >
> > > > > http://issues.apache.org/jira/browse/MYFACES-703
> > > > >
> > > > >To my surprise, it seems this bug was ignored. I don't know exactly
> why,
> > > but if >you let me say it, you should be careful with this type of
> things.
> > > It's highly >dissapointing to upgrade to one new version and discover
> that
> > > part of your >application is not working anymore. In my case, I have
> decided
> > > to spent all the >day trying to find what happened, to finally discover
> that
> > > it was not my fault, but >a JIRA issue apparently ignored. Maybe we are
> > > loosing Myfaces followers if we >don't take care of this things (just a
> > > thought).
> > > >
> > > > Maybe you should submit a patch (just a thought)?
> > > >
> > > > >
> > > > >Regards,
> > > > >Enrique Medina.
> > > >
> > >
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>


--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Mime
View raw message