myfaces-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Schofield <sean.schofi...@gmail.com>
Subject Re: overnight side-effect on tree2
Date Wed, 03 Aug 2005 18:46:22 GMT
There was a change yesterday ...


Author: schof
Date: Tue Aug  2 15:40:43 2005
New Revision: 227101

URL: http://svn.apache.org/viewcvs?rev=227101&view=rev
Log:
Fixes MYFACES-382.

Modified:
   myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java

Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java?rev=227101&r1=227100&r2=227101&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java
(original)
+++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java
Tue Aug  2 15:40:43 2005
@@ -384,7 +384,7 @@
        UIComponent nodeImgFacet = null;

        int bitMask = NOTHING;
-        bitMask += (node.isLeaf()) ? NOTHING : CHILDREN;
+        bitMask += (node.isLeaf() || node.getChildCount() == 0) ?
NOTHING : CHILDREN;
        bitMask += (tree.isNodeExpanded()) ? EXPANDED : NOTHING;
        bitMask += (tree.isLastChild(tree.getNodeId())) ? LAST : NOTHING;
        bitMask += (showLines) ? LINES : NOTHING;



On 8/3/05, Edwin Mercado <emercado@cra.com> wrote:
> Hello,
> I'm using tree2 component :)
> I'm running the nightly built version of MyFaces,
> and I just noticed that when I click twice the same node
> I get the error message shown below. This occurs in
> the Firefox browser, but works just fine in MS IE. Now,
> this was working correctly yesterday afternoon in the Firefox
> browser. Has there been any change to the tree2.HtmlTree
> class since yesterday? Is this a bug? thanks.
> 
> Edwin
> 
> java.lang.NullPointerException
>         at
> org.apache.myfaces.custom.tree2.HtmlTree.isNodeExpanded(HtmlTree.java:165)
>         at
> org.apache.myfaces.custom.tree3.HtmlTree.isNodeExpanded(HtmlTree.java:46)
>         at
> org.apache.myfaces.custom.tree2.HtmlTreeRenderer.decode(HtmlTreeRenderer.jav
> a:112)
>         at
> javax.faces.component.UIComponentBase.decode(UIComponentBase.java:291)
>         at
> org.apache.myfaces.custom.tree2.UITreeData.processDecodes(UITreeData.java:14
> 1)
>         at
> org.apache.myfaces.custom.tree2.HtmlTree.processDecodes(HtmlTree.java:92)
>         at
> javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:39
> 3)
>         at javax.faces.component.UIForm.processDecodes(UIForm.java:51)
>         at
> javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:39
> 3)
>         at
> javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:128)
>         at
> org.apache.myfaces.lifecycle.LifecycleImpl.applyRequestValues(LifecycleImpl.
> java:176)
>         at
> org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:71)
>         at javax.faces.webapp.FacesServlet.service(FacesServlet.java:94)
>         at
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:427)
>         at
> org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebAppl
> icationHandler.java:822)
>         at
> org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsF
> ilter.java:112)
>         at
> org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebAppl
> icationHandler.java:813)
>         at
> org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandl
> er.java:494)
>         at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:569)
>         at org.mortbay.http.HttpContext.handle(HttpContext.java:1482)
>         at
> org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext
> .java:624)
>         at org.mortbay.http.HttpContext.handle(HttpContext.java:1434)
>         at org.mortbay.http.HttpServer.service(HttpServer.java:896)
>         at org.mortbay.http.HttpConnection.service(HttpConnection.java:814)
>         at
> org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:981)
>         at org.mortbay.http.HttpConnection.handle(HttpConnection.java:831)
>         at
> org.mortbay.http.SocketListener.handleConnection(SocketListener.java:244)
>         at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:366)
>         at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534)
>

Mime
View raw message