From dev-return-70868-archive-asf-public=cust-asf.ponee.io@myfaces.apache.org Thu May 16 07:52:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E8AA518066B for ; Thu, 16 May 2019 09:52:29 +0200 (CEST) Received: (qmail 16923 invoked by uid 500); 16 May 2019 07:52:29 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 16902 invoked by uid 99); 16 May 2019 07:52:29 -0000 Received: from Unknown (HELO mailrelay2-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 May 2019 07:52:29 +0000 Received: from hosoni.local (ip4d155f45.dynamic.kabel-deutschland.de [77.21.95.69]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 528F12C06 for ; Thu, 16 May 2019 07:52:28 +0000 (UTC) Subject: Re: [Tobago] maven build problem with javascript compression To: dev@myfaces.apache.org References: From: Udo Schnurpfeil Openpgp: preference=signencrypt Autocrypt: addr=lofwyr@apache.org; prefer-encrypt=mutual; keydata= mQINBE66zekBEACmiIBR1Be2T4/Ub3BycQNYuVRYML1ZrCx12uo/vLeLHbnpPLTpCAl+ZDD5 XPbqHwdKDY161+n3Rf7EFCF+LDlJ3rqGRHJIrUn2CoNgtFX+GpFoOyQ2Q2snUxZ6qG8MNaXc cEMTg2vsZerf10sLG21ZeM+kNxn0sLQ8RlOWr5nmTXrSwa5mZ3QsSkmUDahMi/BGjVIT2tXL zp9ZyDmo6aH0Mabe1NN0GTwSmHoOtskCdj2ltuDMMzW2hgPda6bji8GpyiOYfAuvkM8dWmiw yUt/9zNaam9CeVDhccdbjO2qUYGkkBqWKGYmE62m4Dpb1FMif2NViuThxsW0PSASMzLuX62R Yo5WUTZLNtAbTzyT6N2IlDwzFMVGDN8Lhfj93OLHVVtQZcFuoSWEaoTORd4ckU3mCFD5FqbK fSS7PDbTQ4YuI6K/0hxl2s59cefVYb/k577HTP4GQ/bOa6dDwx0gHtMK5TvVlv4tTOJz34dq wN1+CKlB7xNR7ivMQVa8MDoWDV0fHY509ABo2+sg2zDr/1s8REXnHgE4XJ2mPCbPPDt91Nt8 utIVxNs6Zua8ZyORyy3gIQA26gpb9U688MvJOaG8PYvPzTUb5yOrt7dnMYzgUIcMpGFILk10 km2lamQlGo1nl7bvmLL69CalQd+vGCje/RBwEsAtHJHObSUmZQARAQABtCNVZG8gU2NobnVy cGZlaWwgPGxvZnd5ckBhcGFjaGUub3JnPokCQQQTAQIAKwIbAwUJEswDAAYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AFAlCY8Q4CGQEACgkQARtGtrbNMoD5ZA/+OThOywqFj5iah8dZKFvL 8f7MTPAYmjNlTJ5ScMxTkrcBU4qI61Xp5jN4ucX3qisxswgsYncCuLopKaxqAcdRN0AWY5/m QBSV6EGJ8rhocb4M6FTHbOfqaJdqSAeRs1mL83a0LothB6NxpAwfIt8f9NXbdhZCPA4Ducj+ fkIWzrFzRLiubmlQomDyUZi7m8tAbMNPEG1TWpSnTsorKoPP2B/2a7JE01tsA+LvxmqkFyqh 82G0NIDEWb6XfK4YTU0Aeq+LNoyqkDFawMGxT1PRYKjBuJojPCzzHeFJo9BsLsfJZ/NbRG5R 3Ak3KS3pZXa6P/NrO7yjXily3JmLNMIdszQeKya+AGLFa/tf9/eDKDSseQBv0Xnrp9JZ48Jm 6oao3E2I49q5D+lKny8yYpBoYHvJpRdXafYKGcpBKchJ5HQ7UrjCbbKwOqRrwHTaFotH6L/g AkZSsOPXi1gSedDBCGfr3EJadqUUIF2E9pMRPumxmUniqHYGPNUfx46WkH5MLB4pQcARfVxn UPFMiPdc8xEHPUDIxdXGo1je0K3PQ8v3HRkYxTZHXPZHdzesl3NyL3SQOl1Ochbblafcw2nC BDTZta3lrTF6h3AGE5bad0DRpT6rAtGKOwWfA2EprD+s0d1gHKWhq6PhtE1X0hdS+NAc1sfm YkGEYeO6s92m8FK5Ag0ETrrN6QEQALAICJLQfmsqpAy/zWU54S12dCgOCBxc0RF2n1HZL95c 77XUXIJvBcFJtu+rru8xJCVjmGJnb2Al0Kxm6Rq4Qy45u2bL9mVZ5sR//zRXXVhAWrxDFLhj BnWTdOtPxxjM7NnssWvAwjHHfr9jz7NB7C9+LzLNcEWhxkSi6BVPSvDF3wM/LdZeTP9lLJ3V Xupw8IrSrLr+xzScIUepP/2V2Cy0xbItWWfBsX1ym8TyFFmbm68Si2/g3gRU5c8xajGe34bW Qy2YoOa/jrSCG7LxvbSf9CIxTwwpcCOgmnFnSprelaXcgKOONVWYoPLCoztdwoII523PN2X2 qpX7mNQI+9z24rUQEnacm117PIsdlBRN0WrHK2/ek74zMy2xq/YMXww760iIEWulsFlMGbDj h/R1eVpt6ST7PgakSLY+zGSUdEAB8vNI2nkgESJ2HWFPYYlZGiReSZsVCtq+Km9IWqhM6LTE 4fIQNNK6XnvZzsKHJ6zQNPaAjrWZdL4o6c9xezU9fkfr/QX2CjddRo3uuMXOzKLNc3697XD3 cGrTvF8oKpjIOrLtQqnMxHUO2v3HDkzPcVnZPh8JEZ0qjEt2FOcj/po4bWpo4aYROkTYVuK6 A3qWiyD0UEXgmtRVB2aeP1NaW9NC8eLsULPW7BgI/mdEhLM+uy7NxmJ9AzvvWfZlABEBAAGJ AiUEGAECAA8FAk66zekCGwwFCRLMAwAACgkQARtGtrbNMoBtsg//Q2jt2sT9yo0oTIGDUl4v J7v/WZez9JJHUFgBlvTAvNdbYFuBfOR/dHFJYynFRELAsjZdE8X2MobczL6txetIhAIO86J1 KE8BXgVH1LX2PBEWG90LeIC2AhNimTWTo1NcoPSfF1bbWJ/L9M98Ir0WHhrnn7NZIGgQQzpT 5CLd7FZjVJPmdWiO8da5svwaK2omSpucu/TVOkd7jyAuBLajWX2mOjYWE/fD732XkpqcX33i IigTGRT3CfnsNKYYxpcXQqoTTFWsagAUbm/IWh3qbrmPy7/kokmUWgbBi2xsNl8lvfEfDqmD xDwjuYfR92h1HcQCEZX6k7sCyp3xYTY85iNtWqS+9qAHijS+BlJHS0wKh3bYftU3rcNhxRVY 0K8UOTlukMh2jlpywkKSRiMOPhRnvzNAr7CQwVZwML3oGwK/MTQoV9vhPaB8Blp+5dl+dQgF eNt/+taiZKjHsSw74tWOBUbfH8t0q9hQWCrwIXXEsYMMnOADgUwDJMQK5Upy7ZwwWcpAkYv2 8xap2Z8mn/nfVDe7z3SFmMTp1rGVZZEM4e3yBj2+PJdOSjovk+0xadNQng4GB6K384yczxIm Ox0jf2uWOAbMeo8hTMCsbiI2Y5QdlNfUVZECTz3rswNWCac8exhjCvJn1erGGK71M0jGvidi dDVM9RbKfHdhrxI= Message-ID: <88ad88ef-6450-6dc2-e24c-2cf96f35310f@apache.org> Date: Thu, 16 May 2019 09:52:25 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------C51961A5D65274B7BDFDEF0C" Content-Language: en-US This is a multi-part message in MIME format. --------------C51961A5D65274B7BDFDEF0C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgVm9sa2VyLAoKaXQgc2VlbXMgdG8gbWUsIHRoZSBjbG9zdXJlIGNvbXBpbGVyIG1pc3Vu ZGVyc3RhbmRzwqAgdGhlICJkZWxldGUiCm9wZXJhdG9yLiBJbiB0aGlzIGNhc2UgImRlbGV0 ZSIgaXMgYSBmdW5jdGlvbiBvZiBGb3JtRGF0YSAobm90IGEgdmVyeQpnb29kIGNob2ljZSBm b3IgYSBmdW5jdGlvbiBuYW1lIElNSE8uCgpJIHdpbGwgdXBkYXRlIHRoZSBjbG9zdXJlIGNv bXBpbGVyLiBXaXRoIHRoZSBjdXJyZW50IHZlcnNpb24sIGl0IHNlZW1zCnRvIHdvcmsgY29y cmVjdGx5LCBidXQgSSd2ZSB0byBmaXggdHdvIG90aGVyICJkZWxldGUiLXN0YXRlbWVudHMu CgpSZWdhcmRzLAoKVWRvCgpBbSAwOS4wNS4xOSB1bSAwODo1NyBzY2hyaWViIFZvbGtlciBX ZWJlcjoKPiBIaSwKPgo+IHRoZSBqYXZhc2NyaXB0IGNvbXByZXNzaW9uIGZhaWxzIG9uIG15 IGJ1Z2ZpeCBmb3LCoFRvYmFnbyAyOiBGaWxlRHJvcAo+IGRpZCBub3Qgd29yayB3aXRoIG11 bHRpcGxlPWZhbHNlCj4gPGh0dHBzOi8vaXNzdWVzLmFwYWNoZS5vcmcvamlyYS9icm93c2Uv VE9CQUdPLTE5ODk+IHdpdGg6Cj4KPiBbSU5GT10gRXhlY3V0ZWQgdGFza3MKPiBbSU5GT10K PiBbSU5GT10gLS0tIGV4ZWMtbWF2ZW4tcGx1Z2luOjEuMTpleGVjIChjb21wcmVzcy1zdGFu ZGFyZCkgQAo+IHRvYmFnby10aGVtZS1zdGFuZGFyZCAtLS0KPiBbSU5GT10KPiAvaG9tZS93 ZWJlci93b3JrL215ZmFjZXMvdG9iYWdvL3RvYmFnby0yLngvdG9iYWdvLXRoZW1lL3RvYmFn by10aGVtZS1zdGFuZGFyZC90YXJnZXQvamF2YXNjcmlwdC1taW4vc3RhbmRhcmQvc2NyaXB0 L3RvYmFnby5taW4uanM6MTk0NDoKPiBFUlJPUiAtIFBhcnNlIGVycm9yLiBtaXNzaW5nIG5h bWUgYWZ0ZXIgLiBvcGVyYXRvcgo+IFtJTkZPXcKgwqDCoMKgwqDCoMKgwqDCoMKgIGZvcm1E YXRhLmRlbGV0ZShjbGllbnROYW1lKTsKPiBbSU5GT13CoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF4KPiBbSU5GT10KPgo+IGhlcmUgaXMg dGhlIHJlbGV2YW50IGNvZGUgcGFydDoKPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gMTk0MMKg wqDCoMKgwqDCoMKgwqAgdmFyIGZvcm1EYXRhID0gbmV3IEZvcm1EYXRhKFRvYmFnby5mb3Jt KTsKPiAxOTQxwqDCoMKgwqDCoMKgwqDCoCB2YXIgZmlsZURhdGEgPSBmb3JtLmRhdGEoInRv YmFnby1maWxlLWRyYWctYW5kLWRyb3AtZmlsZXMiKTsKPiAxOTQywqDCoMKgwqDCoMKgwqDC oCBpZiAoZmlsZURhdGEgJiYgZmlsZURhdGEuZmlsZXMubGVuZ3RoID4gMCkgewo+IDE5NDPC oMKgwqDCoMKgwqDCoMKgwqDCoCB2YXIgY2xpZW50TmFtZSA9IGZpbGVEYXRhLm5hbWU7Cj4g MTk0NMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZvcm1EYXRhLmRlbGV0ZShjbGllbnROYW1lKTsK PiAxOTQ1wqDCoMKgwqDCoMKgwqDCoMKgwqAgZm9yICh2YXIgaSA9IDA7IGkgPCBmaWxlRGF0 YS5maWxlcy5sZW5ndGg7IGkrKykgewo+IDE5NDbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg dmFyIGZpbGUgPSBmaWxlRGF0YS5maWxlc1tpXTsKPiAxOTQ3Cj4gMTk0OMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBmb3JtRGF0YS5hcHBlbmQoY2xpZW50TmFtZSwgZmlsZSk7Cj4gMTk0 OcKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiAxOTUwwqDCoMKgwqDCoMKgwqDCoMKgwqAgZm9y bS5yZW1vdmVEYXRhKCJ0b2JhZ28tZmlsZS1kcmFnLWFuZC1kcm9wLWZpbGVzIik7Cj4gMTk1 McKgwqDCoMKgwqDCoMKgwqAgfQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPgo+IFdoYXQgaXMg d3JvbmcgaW4gcm93IDE5NDQ/IChydW5zIGZpbmUgaW4gdW5jb21wcmVzc2VkIHZlcnNpb24p Cj4KPiBSZWdhcmRzLAo+IMKgwqAgVm9sa2VyIFdlYmVyCj4gLS0gCj4gaW5leHNvIC0gaW5m b3JtYXRpb24gZXhjaGFuZ2Ugc29sdXRpb25zIEdtYkgKPiBPZmVuZXIgU3RyYcOfZSAzMCB8 IDI2MTIxIE9sZGVuYnVyZwo+IHd3dy5pbmV4c28uZGUgPGh0dHA6Ly93d3cuaW5leHNvLmRl Pgo= --------------C51961A5D65274B7BDFDEF0C Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Volker,

it seems to me, the closure compiler misunderstands  the "delete" operator. In this case "delete" is a function of FormData (not a very good choice for a function name IMHO.

I will update the closure compiler. With the current version, it seems to work correctly, but I've to fix two other "delete"-statements.

Regards,

Udo

Am 09.05.19 um 08:57 schrieb Volker Weber:
Hi,

the javascript compression fails on my bugfix for Tobago 2: FileDrop did not work with multiple=false with:

[INFO] Executed tasks
[INFO]
[INFO] --- exec-maven-plugin:1.1:exec (compress-standard) @ tobago-theme-standard ---
[INFO] /home/weber/work/myfaces/tobago/tobago-2.x/tobago-theme/tobago-theme-standard/target/javascript-min/standard/script/tobago.min.js:1944: ERROR - Parse error. missing name after . operator
[INFO]           formData.delete(clientName);
[INFO]                           ^
[INFO]

here is the relevant code part:
-------------------------------------------------------------------------
1940         var formData = new FormData(Tobago.form);
1941         var fileData = form.data("tobago-file-drag-and-drop-files");
1942         if (fileData && fileData.files.length > 0) {
1943           var clientName = fileData.name;
1944           formData.delete(clientName);
1945           for (var i = 0; i < fileData.files.length; i++) {
1946             var file = fileData.files[i];
1947
1948             formData.append(clientName, file);
1949           }
1950           form.removeData("tobago-file-drag-and-drop-files");
1951         }
-------------------------------------------------------------------------

What is wrong in row 1944? (runs fine in uncompressed version)

Regards,
   Volker Weber
--
inexso - information exchange solutions GmbH
Ofener Straße 30 | 26121 Oldenburg
www.inexso.de
--------------C51961A5D65274B7BDFDEF0C--