From dev-return-70407-archive-asf-public=cust-asf.ponee.io@myfaces.apache.org Tue Nov 27 16:55:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5DB8C180677 for ; Tue, 27 Nov 2018 16:55:06 +0100 (CET) Received: (qmail 10852 invoked by uid 500); 27 Nov 2018 15:55:04 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 10349 invoked by uid 99); 27 Nov 2018 15:55:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 15:55:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C3E83C0026 for ; Tue, 27 Nov 2018 15:55:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.581 X-Spam-Level: X-Spam-Status: No, score=-0.581 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id offNjd3ISF-K for ; Tue, 27 Nov 2018 15:55:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A68035F437 for ; Tue, 27 Nov 2018 15:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D7CD0E2618 for ; Tue, 27 Nov 2018 15:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 585482776A for ; Tue, 27 Nov 2018 15:55:00 +0000 (UTC) Date: Tue, 27 Nov 2018 15:55:00 +0000 (UTC) From: "Eduardo Breijo (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MYFACES-4269) [perf] getServletRegistrations is slow and not cached MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MYFACES-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700615#comment-16700615 ] Eduardo Breijo commented on MYFACES-4269: ----------------------------------------- [~tandraschko] the changes look good to me. It makes sense to do the caching in a level above as that should improve performance even more compared to the original caching I did for the "isFacesServlet" method. Thanks! > [perf] getServletRegistrations is slow and not cached > ----------------------------------------------------- > > Key: MYFACES-4269 > URL: https://issues.apache.org/jira/browse/MYFACES-4269 > Project: MyFaces Core > Issue Type: Improvement > Affects Versions: 2.3.2 > Reporter: Thomas Andraschko > Priority: Major > Fix For: 2.3.3 > > Attachments: MYFACES-4269.patch > > > seems like servletContext#getServletRegistrations does internal always a new lookup instead of caching it (on tomcat 9.x) > we can simple cache the FacesServletRegistration -- This message was sent by Atlassian JIRA (v7.6.3#76005)