myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ebreijo closed pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …
Date Thu, 25 Oct 2018 14:55:50 GMT
ebreijo closed pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being
cleared at …
URL: https://github.com/apache/myfaces/pull/23
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/impl/src/main/java/org/apache/myfaces/cdi/view/ViewScopeContextImpl.java b/impl/src/main/java/org/apache/myfaces/cdi/view/ViewScopeContextImpl.java
index 7d47156ba..ff6cc9b51 100644
--- a/impl/src/main/java/org/apache/myfaces/cdi/view/ViewScopeContextImpl.java
+++ b/impl/src/main/java/org/apache/myfaces/cdi/view/ViewScopeContextImpl.java
@@ -254,6 +254,8 @@ public static void destroyAllActive(ViewScopeContextualStorage storage,
FacesCon
                 mbDestroyer.destroy(key.getName(), entry.getValue().getContextualInstance());
             }
         }
+
+        contextMap.clear();
         
         storage.deactivate();
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message