myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
Date Mon, 06 Aug 2018 18:56:00 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570643#comment-16570643
] 

ASF GitHub Bot commented on MYFACES-4249:
-----------------------------------------

pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed
URL: https://github.com/apache/myfaces/pull/15
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
> ---------------------------------------------------------------------------------------
>
>                 Key: MYFACES-4249
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4249
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.2.12, 2.3.1
>            Reporter: Paul Nicolucci
>            Assignee: Paul Nicolucci
>            Priority: Minor
>             Fix For: 2.2.13, 2.3.2
>
>
> Currently we calll             c2 = (char) str.charAt(off+i); when (char) str.charAt(off+i)
was previously stored in the write method to variable c so we can easily just do the following
c2=c and save some string manipulation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message