myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Nicolucci (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (MYFACES-4239) [perf] Additional performance improvements
Date Thu, 28 Jun 2018 17:25:00 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Nicolucci resolved MYFACES-4239.
-------------------------------------
    Resolution: Fixed

> [perf] Additional performance improvements
> ------------------------------------------
>
>                 Key: MYFACES-4239
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4239
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-372
>    Affects Versions: 2.2.12, 2.3.1
>            Reporter: Paul Nicolucci
>            Assignee: Paul Nicolucci
>            Priority: Minor
>             Fix For: 2.2.13, 2.3.2
>
>
> Some performance improvements in :
> 1) ApplicationImpl.java 
> 2) ServletExternalContextImpl.java
> 3) HtmlResponseWriterImpl.java
> 4) HTMLEncoder.java, we also discussed on the mailing list changing encodeURIAtributte
to encodeUriAttribute to fix the typo in the method name so I'll do that here as well.
> 5) ResourceValidationUtils.java
> The following changes were made:
> -  Skip calling ConcurrentHashMap.containsKey since we will call get
> afterward if containsKey == true.
> - Stop using Boolean for variables that don't have a null meaning. If
> null == false, then just use boolean with a default of false.
> - Don't call String.length() constantly for String variables that aren't re-assigned.
> - Change conditional order to avoid calling validateResourceName unless the other conditions
are true



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message