myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Beikov (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-4225) [perf] Cache whether a library exists in ExternalContextResourceLoader
Date Fri, 13 Apr 2018 17:47:00 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437655#comment-16437655
] 

Christian Beikov commented on MYFACES-4225:
-------------------------------------------

Hmm, you are right. I must have overseen that, but it isn't caching that a file doesn't exist.
Is there any reason for that?

> [perf] Cache whether a library exists in ExternalContextResourceLoader
> ----------------------------------------------------------------------
>
>                 Key: MYFACES-4225
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4225
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.2.11
>            Reporter: Christian Beikov
>            Priority: Major
>
> I'm seeing many {{sun.nio.fs.UnixException}} being thrown in the underlying code because {{ExternalContextResourceLoader.libraryExists}}
calls {{ExternalContext.getResource}} which in the end checks if a file exists on the FS.
I'd suggest when the project stage is PRODUCTION, this should be cached. Maybe this could
be done by installing an {{ExternalContextWrapper}} that caches all resource lookups? I just
see that parsing a XHTML causes many exceptions to be thrown internally which negatively affects
performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message