myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to open a popup does not work
Date Wed, 07 Mar 2018 12:05:51 GMT
lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to open a popup does
not work
URL: https://github.com/apache/myfaces-tobago/pull/7#discussion_r172821754
 
 

 ##########
 File path: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/CommandMap.java
 ##########
 @@ -104,14 +104,16 @@ public static CommandMap merge(final CommandMap m1, final CommandMap
m2) {
             c1.merge(c2);
           }
         } else {
-          for (final Map.Entry<ClientBehaviors, Command> entry : m2.getOther().entrySet())
{
-            final ClientBehaviors key = entry.getKey();
-            final Command value = entry.getValue();
-            if (m1.other.containsKey(key)) {
-              final Command command = m1.other.get(key);
-              command.merge(value);
-            } else {
-              m1.addCommand(key, value);
+          if (m1.getOther() != null && m2.getOther() != null) {
 
 Review comment:
   Please use "other" instead of "getOther()" for internal calls (performance).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message