From dev-return-69087-archive-asf-public=cust-asf.ponee.io@myfaces.apache.org Mon Jan 29 21:05:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A1DA6180654 for ; Mon, 29 Jan 2018 21:05:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 91CD9160C31; Mon, 29 Jan 2018 20:05:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D9861160C2F for ; Mon, 29 Jan 2018 21:05:05 +0100 (CET) Received: (qmail 81946 invoked by uid 500); 29 Jan 2018 20:05:05 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 81930 invoked by uid 99); 29 Jan 2018 20:05:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 20:05:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C08EFCDDF2 for ; Mon, 29 Jan 2018 20:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.591 X-Spam-Level: X-Spam-Status: No, score=-0.591 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_FAIL=0.919, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id B5_XW57z0PRx for ; Mon, 29 Jan 2018 20:05:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2DE1C5F2F0 for ; Mon, 29 Jan 2018 20:05:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFB97E01DA for ; Mon, 29 Jan 2018 20:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5D03E240FE for ; Mon, 29 Jan 2018 20:05:00 +0000 (UTC) Date: Mon, 29 Jan 2018 20:05:00 +0000 (UTC) From: "Thomas Andraschko (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (MYFACES-4133) Don't deserialize the ViewState-ID if the state saving method is server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MYFACES-4133?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 343942#comment-16343942 ]=20 Thomas Andraschko edited comment on MYFACES-4133 at 1/29/18 8:04 PM: --------------------------------------------------------------------- [~stockli] Seems like HMAC is already used. If not, please create a new iss= ue. was (Author: tandraschko): [~stockli] Seems like HMAC is already used. If not, please create a new iss= ue. * Visual > Don't deserialize the ViewState-ID if the state saving method is server > ----------------------------------------------------------------------- > > Key: MYFACES-4133 > URL: https://issues.apache.org/jira/browse/MYFACES-4133 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Affects Versions: 2.2.12 > Reporter: Peter St=C3=B6ckli > Assignee: Thomas Andraschko > Priority: Major > Fix For: 2.3.0 > > Attachments: 2.1.x-r1817658-r1817712.patch, MYFACES-4133.patch, t= runk-r1817658-r1817806.patch > > > Currently the ViewState-ID provided by the user is deserialized via Java = deserialization even when the {{javax.faces.STATE_SAVING_METHOD}} is set to= {{server}} (the default). > The deserialization in this case is unecessary and most likely even slowe= r than just sending the ViewState Id directly. > If a developer now disables the ViewState encryption by setting {{org.apa= che.myfaces.USE_ENCRYPTION}} to {{false}} (against the [MyFaces security ad= vice|https://wiki.apache.org/myfaces/Secure_Your_Application]) he might hav= e unintentionally introduced a dangerous remote code execution (RCE) vulner= ability as described [here|https://www.alphabot.com/security/blog/2017/java= /Misconfigured-JSF-ViewStates-can-lead-to-severe-RCE-vulnerabilities.html]. > This has been discussed before on [Issue MYFACES-4021|https://issues.apac= he.org/jira/browse/MYFACES-4021]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)