Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Tue, 19 Dec 2017 18:41:00 +0000 (UTC)
From: "Paul Nicolucci (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <JIRA.13120312.1511379003000.495232.1513708860247@Atlassian.JIRA>
In-Reply-To: <JIRA.13120312.1511379003000@Atlassian.JIRA>
References: <JIRA.13120312.1511379003000@Atlassian.JIRA> <JIRA.13120312.1511379003038@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MYFACES-4175) template XHTML file fails to load
 when in /resources dir
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 19 Dec 2017 18:41:04 -0000


    [ https://issues.apache.org/jira/browse/MYFACES-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297221#comment-16297221 ] 

Paul Nicolucci commented on MYFACES-4175:
-----------------------------------------

In order to open any xhtml from any jar wouldn't there need to be a mapping defined for each such view in the web.xml for the FacesServlet?  Looking here: http://arjan-tijms.omnifaces.org/p/jsf-23.html for example if you defined /foo then you would still require foo.xhtml in order for that to be be loaded. I'm not quite sure what to test here. I have not committed these changes until we determine if it is dangerous to do so. As an FYI I'll be out for about 1.5 weeks starting Thursday. I'll try to do some testing of any solution that are created on the open JIRAs while I'm out to help.

> template XHTML file fails to load when in /resources dir
> --------------------------------------------------------
>
>                 Key: MYFACES-4175
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4175
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.3.0-beta
>            Reporter: Jay Sartoris
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: JSFTestResources.war, MYFACES-4175.patch
>
>
> Please consider the following scenario, I've attached a sample app. 
> I have a template in the resources/templates directory.  The request to localhost:8080/JSFTestResources/mapViewIdToResource.jsf fails when MyFaces to load the basicTemplate.xhtml  file which is located in the /resources/templates directory for the composite component.  The backing bean uses the ResourceHandler to create the view resources.
> The reason this fails in JSF 2.3 is due to the change in the org.apache.myfaces.resource.RootExternalContextResourceLoader.getResourceURL(String) method.  
> In JSF 2.3, the method added a check to see if the resourceId starts wiht the contractsDirectory or resourcesDirectory.  If it does then the getResourceURL returns null which tells the ResourceLoader that the resource does not exist.  In JSF 2.2, those checks were not there.
> I checked the change history for this class and I see that MYFACES-4105 added this change.  In that JIRA I see the comment made that says:
> "One last review is required to check if xhtml files under forbidden extensions are being loaded (/resources, /contracts and so on)."
> Therefore, this falls in to the JIRA comment mentioned above.  To me, the test I've attached seems to be a valid scenario and MyFaces should be allowing this resource to be found instead of returning null.  I don't see anywhere in the spec that says MyFaces should be behaving in that manner. Please correct me if I'm wrong.
> Also, this app works with MyFaces JSF 2.2 and also with Mojarra JSF 2.3.  
> With MyFaces JSF 2.3 I get a NPE:
> java.lang.NullPointerException
> 	com.test.MapResourcePathBean.mapViewIdToResource(MapResourcePathBean.java:56)
> 	sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:90)
> 	sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
> 	java.lang.reflect.Method.invoke(Method.java:508)
> 	javax.el.BeanELResolver.invoke(BeanELResolver.java:158)
> 	javax.el.CompositeELResolver.invoke(CompositeELResolver.java:79)
> 	org.apache.el.parser.AstValue.getValue(AstValue.java:159)
> 	org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:184)
> 	org.apache.myfaces.view.facelets.el.ContextAwareTagValueExpression.getValue(ContextAwareTagValueExpression.java:93)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)