myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Andraschko (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Comment Edited] (MYFACES-4169) selectOneRadio grouping broken
Date Sun, 12 Nov 2017 14:14:01 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248866#comment-16248866
] 

Thomas Andraschko edited comment on MYFACES-4169 at 11/12/17 2:13 PM:
----------------------------------------------------------------------

Hmm not sure about this one... I currently think about that solution inside UISelectOne:


{code:java}
    @Override
    public void processValidators(FacesContext context)
    {
        String group = getGroup();
        if (group != null && !group.isEmpty() && getValueExpression("value")
== null)
        {
            // do nothing
            // the "root" component must be processed and validated, we don't have a value
binding here
            return;
        }
        
        super.processValidators(context);
    }
{code}

maybe you could give it a try?





was (Author: tandraschko):
Hmm not sure about this one... I currently think about that solution inside UISelectOne:


{code:java}
    @Override
    public void processValidators(FacesContext context)
    {
        String group = getGroup();
        if (group != null && getValueExpression("value") == null)
        {
            // do nothing
            // the "root" component must be processed and validated, we don't have a value
binding here
            return;
        }
        
        super.processValidators(context);
    }
{code}

maybe you could give it a try?




> selectOneRadio grouping broken
> ------------------------------
>
>                 Key: MYFACES-4169
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4169
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-372
>    Affects Versions: 2.3.0-beta
>            Reporter: Paul Nicolucci
>            Assignee: Thomas Andraschko
>             Fix For: 2.3.0
>
>         Attachments: JSF23SelectOneRadioGroup.war, SelectOneRadioGroupBean.java, index.xhtml
>
>
> I was testing out the new group attribute on the <h:selectOneRadio/> component
and found that it does not look to work in all scenarios:
> I've provided a test application to shows a working scenario and then multiple scenarios
that I think should work but don't.
> The app can be deployed on tomcat. 
> You can drive a request to the index page which will contain the links what doesn't work:

> http://localhost:8080/JSF23SelectOneRadioGroup/index.xhtml
> Or you can directly verify what does not work by sending requests to:
> localhost:8080/JSF23SelectOneRadioGroup/error.xhtml
> localhost:8080/JSF23SelectOneRadioGroup/error2.xhtml
> localhost:8080/JSF23SelectOneRadioGroup/error3.xhtml
> localhost:8080/JSF23SelectOneRadioGroup/error4.xhtml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message