myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leonardo Uribe <lu4...@gmail.com>
Subject Re: Dev Discussion - JSF 2.3 ResourceVisitOption.TOP_LEVEL_VIEWS_ONLY different between MyFaces and Mojarra
Date Fri, 24 Nov 2017 01:00:44 GMT
Hi

I think MyFaces behavior is correct here. The reason is you will never add
views inside META-INF or WEB-INF folders, but you could add templates
there. But a template is not a view. That is what I understand with "top
level views".

regards,

Leonardo Uribe

2017-11-23 19:41 GMT-05:00 Thomas Andraschko <andraschko.thomas@gmail.com>:

> I think we should align myfaces here. A issue + patch would be great.
>
>
> Am Samstag, 18. November 2017 schrieb Paul Nicolucci :
>
>> The javadoc for ResourceVisitOption.html says the following:
>> https://javaee.github.io/javaee-spec/javadocs/javax/faces/
>> application/ResourceVisitOption.html
>>
>> public static final *ResourceVisitOption*
>> <https://javaee.github.io/javaee-spec/javadocs/javax/faces/application/ResourceVisitOption.html>
>>  TOP_LEVEL_VIEWS_ONLY
>> Only visit resources that are top level views, i.e. views that can be
>> used to serve a request as opposed to those that can only be used for
>> includes.
>>
>> Thanks,
>>
>> Paul Nicolucci
>>
>>
>> [image: Inactive hide details for Thomas Andraschko ---11/18/2017
>> 07:22:32 AM---Did you checked the spec texts? 2017-11-17 19:56 GMT+01]Thomas
>> Andraschko ---11/18/2017 07:22:32 AM---Did you checked the spec texts?
>> 2017-11-17 19:56 GMT+01:00 Paul Nicolucci <pnicoluc@us.ibm.com>:
>>
>> From: Thomas Andraschko <andraschko.thomas@gmail.com>
>> To: MyFaces Development <dev@myfaces.apache.org>
>> Date: 11/18/2017 07:22 AM
>> Subject: Re: Dev Discussion - JSF 2.3 ResourceVisitOption.TOP_LEVEL_VIEWS_ONLY
>> different between MyFaces and Mojarra
>> ------------------------------
>>
>>
>>
>> Did you checked the spec texts?
>>
>> 2017-11-17 19:56 GMT+01:00 Paul Nicolucci <*pnicoluc@us.ibm.com*>:
>>
>>    Hello,
>>
>>    I was testing out the ResourceHandler.getViewResources() today and I
>>    noticed that we have quite a behavior different between the two
>>    implementations.
>>
>>    Take the following application for example:
>>
>>    testApplication
>>    - /depth2/index.xhtml
>>    -META-INF/index.xhtml
>>    -WEB-INF/index.xhtml
>>    - index.xhtml
>>    - test
>>
>>    Mojarra getViewResources( call with ResourceVisitOptions )
>>    /index.xhtml /depth2/index.xhtml
>>
>>    Mojarra getViewResources ( call without ResourceVisitOptions )
>>    /index.xhtml /depth2/index.xhtml META-INF/index.xhtml
>>    WEB-INF/index.xhtml
>>
>>    MyFaces getViewResources( call with ResourceVisitOptions )
>>    /index.xhtml /depth2/index.xhtml
>>
>>    MyFaces getViewResources( call without ResourceVisitOptions )
>>    /index.xhtml /test /depth2/index.xhtml
>>
>>    In MyFaces if we use the ResourceVisitOptions then we filter out any
>>    views that don't contain a valid suffix ( in the above case /test ). In
>>    addition MyFaces never returns any views in WEB-INF and META-INF
>>
>>    In Mojarra if we use the ResourceVisitOptions then anything in
>>    WEB-INF and META-INF is not included. In addition Mojarra never returns any
>>    views without a valid suffix.
>>
>>    I think we need a dev discussion to determine if we want to stick
>>    with our current behavior or change it.
>>
>>    Thanks,
>>
>>    Paul Nicolucci
>>
>>
>>
>>

Mime
View raw message