Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Sun, 8 Oct 2017 15:25:00 +0000 (UTC)
From: "Werner Punz (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <JIRA.13105335.1506501063000.1112.1507476300101@Atlassian.JIRA>
In-Reply-To: <JIRA.13105335.1506501063000@Atlassian.JIRA>
References: <JIRA.13105335.1506501063000@Atlassian.JIRA> <JIRA.13105335.1506501063811@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (MYFACES-4160) ViewState not written for
 Ajax request
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 08 Oct 2017 15:25:06 -0000


    [ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196164#comment-16196164 ] 

Werner Punz edited comment on MYFACES-4160 at 10/8/17 3:24 PM:
---------------------------------------------------------------

I am done with the needed changes, and I would  be ready to commit however.

before committing it I would like to check the the code in the JSF - CDI example app. However I cannot get it up and running, there are several issues.
a) The code references websockets, but the pom.xml does not have a websocket reference - thats easy to fix.
b) Whenever I dump the war into Tomcat I get a CDI error:

nfig.annotation.Tomcat7AnnotationLifecycleProvider
08-Oct-2017 17:09:45.158 SCHWERWIEGEND [main] org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces An error occured while initializing MyFaces: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery
 java.lang.IllegalStateException: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery
	at org.apache.webbeans.container.InjectableBeanManager.checkAfterBeanDiscoveryProcessed(InjectableBeanManager.java:402)
	at org.apache.webbeans.container.InjectableBeanManager.getBeans(InjectableBeanManager.java:121)
	at org.apache.myfaces.cdi.util.CDIUtils.lookup(CDIUtils.java:51)
	at org.apache.myfaces.flow.cdi.DefaultCDIFacesFlowProvider.getAnnotatedFlows(DefaultCDIFacesFlowProvider.java:52)
	at org.apache.myfaces.flow.impl.AnnotatedFlowConfigurator.configureAnnotatedFlows(AnnotatedFlowConfigurator.java:42)
	at org.apache.myfaces.config.FacesConfigurator.configureFlowHandler(FacesConfigurator.java:1700)
	at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:614)
	at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:452)
	at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:74)

This must be fixed on the codeside. Shall I open a Jira issue for that one?

So there is no real way to test this stuff atm. I ran my usual integration tests (which I host on github sort of as a workspace for myself) which I use for development. but a final test on my side is still pending.

Shall I push the code anyway and someone with a working running config wants to test it? The changes do not break anything, my about 20-30 or so integration tests I have on the code pass perfectly, but I would love to see the new behavior to be tested (aka the namespaced changes).


was (Author: werpu):
I would  be ready to commit however.

before committing it I would like to check the the code in the JSF - CDI example app. However I cannot get it up and running, there are several issues.
a) The code references websockets, but the pom.xml does not have a websocket reference - thats easy to fix.
b) Whenever I dump the war into Tomcat I get a CDI error:

nfig.annotation.Tomcat7AnnotationLifecycleProvider
08-Oct-2017 17:09:45.158 SCHWERWIEGEND [main] org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces An error occured while initializing MyFaces: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery
 java.lang.IllegalStateException: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery
	at org.apache.webbeans.container.InjectableBeanManager.checkAfterBeanDiscoveryProcessed(InjectableBeanManager.java:402)
	at org.apache.webbeans.container.InjectableBeanManager.getBeans(InjectableBeanManager.java:121)
	at org.apache.myfaces.cdi.util.CDIUtils.lookup(CDIUtils.java:51)
	at org.apache.myfaces.flow.cdi.DefaultCDIFacesFlowProvider.getAnnotatedFlows(DefaultCDIFacesFlowProvider.java:52)
	at org.apache.myfaces.flow.impl.AnnotatedFlowConfigurator.configureAnnotatedFlows(AnnotatedFlowConfigurator.java:42)
	at org.apache.myfaces.config.FacesConfigurator.configureFlowHandler(FacesConfigurator.java:1700)
	at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:614)
	at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:452)
	at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:74)

This must be fixed on the codeside. Shall I open a Jira issue for that one?

So there is no real way to test this stuff atm. I ran my usual integration tests (which I host on github sort of as a workspace for myself) which I use for development. but a final test on my side is still pending.

Shall I push the code anyway and someone with a working running config wants to test it? The changes do not break anything, my about 20-30 or so integration tests I have on the code pass perfectly, but I would love to see the new behavior to be tested (aka the namespaced changes).


> ViewState not written for Ajax request
> --------------------------------------
>
>                 Key: MYFACES-4160
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4160
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.3.0-beta
>            Reporter: Thomas Andraschko
>            Assignee: Werner Punz
>             Fix For: 2.3.0
>
>
> If you run the application from MYFACES-4156 via mvn jetty:run, the viewStateId isn't rendered again after the first ajax request.
> Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it skips.
> [~lu4242] Could you please check that?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)