Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 936B2200D03 for ; Sat, 9 Sep 2017 10:35:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 91E1F1609E8; Sat, 9 Sep 2017 08:35:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D70991609DA for ; Sat, 9 Sep 2017 10:35:11 +0200 (CEST) Received: (qmail 11233 invoked by uid 500); 9 Sep 2017 08:35:10 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 11210 invoked by uid 99); 9 Sep 2017 08:35:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Sep 2017 08:35:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 187631A26C9 for ; Sat, 9 Sep 2017 08:35:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.718 X-Spam-Level: * X-Spam-Status: No, score=1.718 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oFAJG3VzvjGg for ; Sat, 9 Sep 2017 08:35:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 989A85FBEA for ; Sat, 9 Sep 2017 08:35:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 98EBCE08A0 for ; Sat, 9 Sep 2017 08:35:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4A72624147 for ; Sat, 9 Sep 2017 08:35:02 +0000 (UTC) Date: Sat, 9 Sep 2017 08:35:02 +0000 (UTC) From: "Dennis Kieselhorst (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MYFACES-4140) NullPointerException instead of InvalidViewIdException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 09 Sep 2017 08:35:12 -0000 [ https://issues.apache.org/jira/browse/MYFACES-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159837#comment-16159837 ] Dennis Kieselhorst commented on MYFACES-4140: --------------------------------------------- Well I'm unsure how to fix it. Simply adding a null check and throw InvalidViewIdException will probably cause side effects in other cases. The code already contains a comment from [~lu4242] "Temporally reverted by TCK issues." > NullPointerException instead of InvalidViewIdException > ------------------------------------------------------ > > Key: MYFACES-4140 > URL: https://issues.apache.org/jira/browse/MYFACES-4140 > Project: MyFaces Core > Issue Type: Bug > Affects Versions: 2.3.0-beta > Reporter: Dennis Kieselhorst > Priority: Minor > Fix For: 2.3.0 > > > In case of an invalid viewId an NPE is thrown instead of InvalidViewIdException. This is reproducible using tobago-example-demo (NavigationTree /content/root-dummy.xhtml). > {noformat} > Caused by: java.lang.NullPointerException > at org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459) > at org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141) > at javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134) > at javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134) > at org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229) > at org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86) > at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597) > at javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527) > at javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551) > at org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130) > at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675) > at javax.faces.component.UIData.encodeEnd(UIData.java:1811) > at javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555) > at javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551) > at javax.faces.render.Renderer.encodeChildren(Renderer.java:95) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)