Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 61AA8200CC9 for ; Mon, 17 Jul 2017 10:41:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5E62A1648B1; Mon, 17 Jul 2017 08:41:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A3B6C1648AD for ; Mon, 17 Jul 2017 10:41:06 +0200 (CEST) Received: (qmail 54356 invoked by uid 500); 17 Jul 2017 08:41:05 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 54346 invoked by uid 99); 17 Jul 2017 08:41:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2017 08:41:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E594E1800FF for ; Mon, 17 Jul 2017 08:41:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.718 X-Spam-Level: * X-Spam-Status: No, score=1.718 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tEGwg6Q0whA6 for ; Mon, 17 Jul 2017 08:41:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B013760DA9 for ; Mon, 17 Jul 2017 08:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D3B21E0984 for ; Mon, 17 Jul 2017 08:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31C3C24766 for ; Mon, 17 Jul 2017 08:41:00 +0000 (UTC) Date: Mon, 17 Jul 2017 08:41:00 +0000 (UTC) From: "Thomas Andraschko (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MYFACES-4124) Wrong user properties map is used when using and onOpen method is invoked MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Jul 2017 08:41:07 -0000 [ https://issues.apache.org/jira/browse/MYFACES-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089501#comment-16089501 ] Thomas Andraschko commented on MYFACES-4124: -------------------------------------------- Looks fine for me, thanks for the patch! > Wrong user properties map is used when using and onOpen method is invoked > --------------------------------------------------------------------------------------- > > Key: MYFACES-4124 > URL: https://issues.apache.org/jira/browse/MYFACES-4124 > Project: MyFaces Core > Issue Type: Bug > Affects Versions: 2.3.0-beta > Environment: WebSphere Application Server Liberty profile > Reporter: Eduardo Breijo > Attachments: MYFACES-4124.patch > > > The tag does not work due to a wrong object being used to get user properties map when the onOpen method from EndpointImpl is called. > Currently, the WEBSOCKET_VALID key is stored in the user properties map of ServerEndpointConfig. When the onOpen method is called, it tries to retrieve the value stored for this key, but it is trying to get it from the wrong user properties map, that is, from the Session map, instead of getting it from the EndpointConfig user properties map. > A patch has been provided to fix this issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)