myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (TOBAGO-1709) Duplicated IDs when using 'labelLayout=segmentLeft' or 'labelLayout=segmentRight'
Date Tue, 18 Apr 2017 18:48:41 GMT

    [ https://issues.apache.org/jira/browse/TOBAGO-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973266#comment-15973266
] 

Hudson commented on TOBAGO-1709:
--------------------------------

SUCCESS: Integrated in Jenkins build Tobago Trunk #861 (See [https://builds.apache.org/job/Tobago%20Trunk/861/])
TOBAGO-1709 Duplicated IDs when using 'labelLayout=segmentLeft' or 'labelLayout=segmentRight'
* the ID of the label-part now has the suffix ::label
* add test for duplicated IDs (hnoeth: [http://svn.apache.org/viewvc/?view=rev&rev=1791818])
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java
* (edit) tobago-trunk/tobago-example/tobago-example-demo/src/main/webapp/script/tobago-test.js


> Duplicated IDs when using 'labelLayout=segmentLeft' or 'labelLayout=segmentRight'
> ---------------------------------------------------------------------------------
>
>                 Key: TOBAGO-1709
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1709
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>            Reporter: Henning Noeth
>            Assignee: Henning Noeth
>             Fix For: 3.1.0
>
>         Attachments: TOBAGO_1709_Duplicated_IDs_when_using__labelLayout_segmentLeft__or__labelLayout_segmentRig.patch
>
>
> The following code produce duplicated IDs on the rendered DIV. It doesn't matter if an
ID is set.
> {code:xml}<tc:segmentLayout extraSmall="6;6">
>   <tc:in id="inputOne" label="Input" labelLayout="segmentLeft"/>
>   <tc:in id="inputTwo" label="Input" labelLayout="segmentRight"/>
> </tc:segmentLayout>{code}
> The rendered result for 'inputOne' is:
> {code:xml}<div class="tobago-segmentLayout row" id="page:mainForm:j_id_1x">
>   <div class="col-xs-6">
>     <div id="page:mainForm:inputOne" class="tobago-label-container form-group">
>       <label for="page:mainForm:inputOne" class="tobago-label col-form-label">Input</label>
>     </div>
>   </div>
>   <div class="col-xs-6">
>     <div id="page:mainForm:inputOne" class="tobago-label-container form-group">
>       <input type="text" name="page:mainForm:inputOne" id="page:mainForm:inputOne::field"
class="tobago-in form-control">
>     </div>
>   </div>
> ...
> </div>{code}
> The result for 'inputTwo' is very similar.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message