Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Tue, 6 Dec 2016 12:41:58 +0000 (UTC)
From: =?utf-8?Q?leve_=C5=9Fipal_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <JIRA.12512479.1309535646000.449491.1481028118521@Atlassian.JIRA>
In-Reply-To: <JIRA.12512479.1309535646000@Atlassian.JIRA>
References: <JIRA.12512479.1309535646000@Atlassian.JIRA> <JIRA.12512479.1309535646226@arcas>
Subject: [jira] [Comment Edited] (PORTLETBRIDGE-217) Test URL should be
 "resources/myImage.jpg?javax.portlet.faces.BackLink=myBackLinkParam"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 06 Dec 2016 12:42:02 -0000


    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-217?page=3Dcom.at=
lassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15725320#comment-15725320 ]=20

leve =C5=9Fipal edited comment on PORTLETBRIDGE-217 at 12/6/16 12:41 PM:
--------------------------------------------------------------------

http://www.allingerie.com - Sexy lingerie black red White Lace open crotch =
bra G string sleepwear women underbust nightwear teddy lingerie set S-XXL V=
isit the image link=20


was (Author: levent45):
allingerie.com - Sexy lingerie black red White Lace open crotch bra G strin=
g sleepwear women underbust nightwear teddy lingerie set S-XXL Visit the im=
age link=20

> Test URL should be "resources/myImage.jpg?javax.portlet.faces.BackLink=3D=
myBackLinkParam"
> -------------------------------------------------------------------------=
--------------
>
>                 Key: PORTLETBRIDGE-217
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-=
217
>             Project: MyFaces Portlet Bridge
>          Issue Type: TCK Challenge
>          Components: TCK
>    Affects Versions: 2.0.0
>            Reporter: Wesley Hales
>            Assignee: Michael Freedman
>         Attachments: pbr-tck.patch, pbr-tck.patch
>
>
> [Alexander Smirnov & Wesley Hales: Red Hat]
> [jsr329-1.0.0]
> [portlet_2_bridge-1_0-final-spec]
> [chapter_6/section_6_5_1/Tests#testImplicitObject,
> chapter_6/section_6_1_3_1/Tests#illegalRedirectRenderTest,
> chapter_4/section_4_2_1/InitMethodTestPortlet#init,
> /testsuite/beans/NonJSFViewBean#getUrl]
> [https://issues.jboss.org/browse/PBR-254?focusedCommentId=3D12611867&page=
=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment=
-12611867
> Many tests failed because of possible TCK issue, that threats URLs not st=
arted with application context as internals.
> Following this logic (and given Oracle's use of encodeActionURL to encode=
 its equivalent of the OutputLink) then encodeAction should do a return por=
tletResponse.encodeURL(target) if the url begins with a / and isn't (this a=
pplication) context-path prefixed. I.e. we need the bridge code to give the=
 portlet container a chance to encode the server/port (construct and absolu=
te url) - typically when the portlet container is remote.
> Sound about right? I know the spec doesn't say anything about this but it=
 seems to fall out from this decision/interpretation. Does your code alread=
y do this? If not should it?
> Mike
> On 6/14/2011 1:29 PM, Michael Freedman wrote:
> > So what you are saying is that because ViewHandler.getResourceURL() is =
defined and it will always append the ContextPath then the spec/impl should=
 assume that urls starting with '/' that don't contain a ContextPath must b=
e out of the application (because all in application urls would have been c=
hanneled through getResourceURL? I.e. just using /xxx as a resource url wit=
hout a context path doesn't work in servlet based JSF. Interesting - okay I=
 see your logic. Please file a JIRA against the TCK indicating the test url=
 it should use ought to be "resources/myImage.jpg?javax.portlet.faces.BackL=
ink=3DmyBackLinkParam". If possible please make the needed changes yourself=
 and verify (and then submit the jira with either the details of the code c=
hange or a patch file).
> >
> > I will file a bug against the RI concerning its not treating / as an ex=
ternal url - and since we are changing the test/fixing a bug will just incl=
ude in the 2.0.1 release.
> > Mike
> ]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)