myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Lucy <wtl...@gmail.com>
Subject Re: [jira] [Commented] (MYFACES-4050) Validators not invoked for empty selectManyCheckbox components
Date Tue, 21 Jun 2016 12:53:26 GMT
I've tested the fix here locally, with good results.  If there are no
objections to my changing the behavior here then I'll commit the changes.

On Thu, Jun 9, 2016 at 12:15 PM, Bill Lucy (JIRA) <dev@myfaces.apache.org>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/MYFACES-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322783#comment-15322783
> ]
>
> Bill Lucy commented on MYFACES-4050:
> ------------------------------------
>
> The fix I'm proposing here is straightforward - we're overriding
> UIInput.validateValue() in UISelectMany; we need to check
> shouldValidateEmptyFields() in the overridden method.
>
> > Validators not invoked for empty selectManyCheckbox components
> > --------------------------------------------------------------
> >
> >                 Key: MYFACES-4050
> >                 URL: https://issues.apache.org/jira/browse/MYFACES-4050
> >             Project: MyFaces Core
> >          Issue Type: Bug
> >    Affects Versions: 2.2.10
> >         Environment: Tomcat, WebSphere Liberty
> >            Reporter: Bill Lucy
> >         Attachments: MYFACES-4050.patch
> >
> >
> > Custom validators are not invoked for selectManyCheckbox component, if
> the component has no selections made; this can be an issue if we want to
> handle the null/empty case in a validator.  The following context params
> address this case:
> >       <context-param>
> >
>  <param-name>javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL</param-name>
> >               <param-value>true</param-value>
> >       </context-param>
> >
> >       <context-param>
> >           <param-name>javax.faces.VALIDATE_EMPTY_FIELDS</param-name>
> >           <param-value>true</param-value>
> >       </context-param>
> > But these params do not affect the behavior here.  Based on my
> understanding of the spec, it seems that this behavior should be changed.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Mime
View raw message