Return-Path: 
 <dev-return-65268-apmail-myfaces-dev-archive=myfaces.apache.org@myfaces.apache.org>
X-Original-To: apmail-myfaces-dev-archive@www.apache.org
Delivered-To: apmail-myfaces-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6720F18F7B
	for <apmail-myfaces-dev-archive@www.apache.org>;
 Thu, 19 Nov 2015 01:43:12 +0000 (UTC)
Received: (qmail 40563 invoked by uid 500); 19 Nov 2015 01:43:11 -0000
Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org
Received: (qmail 40389 invoked by uid 500); 19 Nov 2015 01:43:11 -0000
Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@myfaces.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@myfaces.apache.org>
List-Post: <mailto:dev@myfaces.apache.org>
List-Id: <dev.myfaces.apache.org>
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Delivered-To: mailing list dev@myfaces.apache.org
Received: (qmail 39571 invoked by uid 99); 19 Nov 2015 01:43:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2015 01:43:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 492882C1F80
	for <dev@myfaces.apache.org>; Thu, 19 Nov 2015 01:43:11 +0000 (UTC)
Date: Thu, 19 Nov 2015 01:43:11 +0000 (UTC)
From: "Leonardo Uribe (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <JIRA.12825642.1430249323000.116022.1447897391296@Atlassian.JIRA>
In-Reply-To: <JIRA.12825642.1430249323000@Atlassian.JIRA>
References: <JIRA.12825642.1430249323000@Atlassian.JIRA>
 <JIRA.12825642.1430249323207@arcas>
Subject: [jira] [Resolved] (MYFACES-3988) An empty tag in a custom tag-lib
 causes an Exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/MYFACES-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3988.
-------------------------------------
       Resolution: Fixed
         Assignee: Leonardo Uribe
    Fix Version/s: 2.2.9

I did a small change, just allow renderer-type and handler-class to receive empty values and interpret them as null. I think that's enough in this case.

> An empty tag in a custom tag-lib causes an Exception
> ----------------------------------------------------
>
>                 Key: MYFACES-3988
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3988
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-344
>    Affects Versions: 2.2.8
>            Reporter: Christopher Meyer
>            Assignee: Leonardo Uribe
>            Priority: Minor
>             Fix For: 2.2.9
>
>
> While developing a custom tag library we added an empty renderer-type tag like this:
> <tag>
>      <tag-name>myinput</tag-name>
>      <component>
>            <component-type>my.test.MyInput</component-type>
>           <renderer-type></renderer-type>
>      </component>
> </tag>
> This causes the following exception:
> Caused by: java.lang.Exception: Value Cannot be Empty
> 	at org.apache.myfaces.view.facelets.compiler.TagLibraryConfigUnmarshallerImpl$LibraryHandler.endElement(TagLibraryConfigUnmarshallerImpl.java:395)
> 	at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
> 	at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanEndElement(Unknown Source)
> 	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
> ...
> This appears to be expected based on the code in TagLibraryConfigUnmarshallerImpl. From what I can see the exception appears to be thrown on elements which are used in another spot. If any of them are empty they will throw the above exception. Wildfly/Glassfish does not have the same behavior, so my assumption is they just ignore it.
> Should the MyFaces code be modified to just continue on without the exception, based on the reference implementation? I can quickly create something if so, I just wanted to bring this up to the community at large since I don't know the reasoning behind the difference of the implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)