myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3957) Disabled h:commandLink results in rendering of a span with onclick
Date Thu, 19 Nov 2015 01:15:10 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012531#comment-15012531
] 

Leonardo Uribe commented on MYFACES-3957:
-----------------------------------------

I tested Mojarra 2.2.12 and I can see that only the onclick is removed from the <span ...>
element, but the patch remove all event listeners. It looks like an special case not documented,
and it has sense just to remove the onclick javascript. I'll modify the patch to do the same,
just remove onclick when the link is disabled.

> Disabled h:commandLink results in rendering of a span with onclick 
> -------------------------------------------------------------------
>
>                 Key: MYFACES-3957
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3957
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>         Environment: Websphere 8.5
>            Reporter: Stephan Knitelius
>         Attachments: MYFACES-3957.patch
>
>
> {code}
>           <h:commandLink disabled="true" onclick="alert('hello')" type="button">link</h:commandLink>
> AND
>           <h:commandLink disabled="true" onclick="alert('hello')" type="button" value="link"
/>
> {code}
> Result in:
> {code}
> <span onclick="alert('hello')" type="button">link</span>
> {code}
> I would have expected to find a disabled <a ...></a> or a span without the
onclick action.
> In comparison a disabled h:commandButton:
> {code}
> <h:commandButton disabled="true" value="button" onclick="alert('hello')" type="button"/>
> {code}
> Results in:
> {code}
> <input name="frmContent:j_id499838546_62f34114" disabled="disabled" id="frmContent:j_id499838546_62f34114"
onclick="alert('hello')" type="button" value="button"></input>
> {code}
> As expected the onclick action is not preformed.
> I would expect similar behaviour from both h:commandButton and h:commandLink.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message