myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Kieselhorst (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Comment Edited] (TOBAGO-1453) SelectManyRendererBase should support Collection
Date Mon, 27 Apr 2015 09:12:38 GMT

    [ https://issues.apache.org/jira/browse/TOBAGO-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513767#comment-14513767
] 

Dennis Kieselhorst edited comment on TOBAGO-1453 at 4/27/15 9:11 AM:
---------------------------------------------------------------------

Reopening because of test failure:
{noformat}
testPageConsistency[\/test\/selectManyListbox\/selectManyListbox-value_xhtml](org.apache.myfaces.tobago.example.test.AutomaticSeleniumTest)
 Time elapsed: 1.124 sec  <<< FAILURE!
java.lang.AssertionError: error on server
Page URL: http://localhost:8080/faces/test/selectManyListbox/selectManyListbox-value.xhtml

---------------------------------------------------------------------------------------------------
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
-->
<html xmlns="http://www.w3.org/1999/xhtml"><head>
<meta content="text/html; charset=iso-8859-1" http-equiv="Content-Type" />
<title>Error - java.lang.StackOverflowError</title>
<style type="text/css">
body, div, span, td, th, caption { font-family: 'Trebuchet MS', Verdana, Arial, Sans-Serif;
font-size: small; }
ul, li, pre { padding: 0; margin: 0; }
h1 { color: #900; }
h2, h2 span { font-size: large; color: #339; }
h2 a { text-decoration: none; color: #339; }
.grayBox { padding: 8px; margin: 10px 0; border: 1px solid #CCC; background-color: #f9f9f9;
 }
#error { color: #900; font-weight: bold; font-size: medium; }
#trace, #tree, #vars { display: none; }
code { font-size: medium; }
#tree dl { color: #006; }
#tree dd { margin-top: 2px; margin-bottom: 2px; }
#tree dt { border: 1px solid #DDD; padding: 4px; border-left: 2px solid #666; font-family:
"Courier New", Courier, mono; font-size: small; }
.uicText { color: #999;  }
.highlightComponent { color: #FFFFFF; background-color: #FF0000;  }
table { border: 1px solid #CCC; border-collapse: collapse; border-spacing: 0px; width: 100%;
text-align: left; }
td { border: 1px solid #CCC; }
thead tr th { padding: 2px; color: #030; background-color: #F9F9F9; }
tbody tr td { padding: 10px 6px; }
table caption { text-align: left; padding: 10px 0; font-size: large; }
</style>
<style media="print" type="text/css">
#trace, #tree, #vars { display: block; }
</style>
<script type="text/javascript" language="javascript">
function toggle(id) {
	var style = document.getElementById(id).style;
	if ("block" == style.display) {
		style.display = "none";
		document.getElementById(id+"Off").style.display = "inline";
		document.getElementById(id+"On").style.display = "none";
	} else {
		style.display = "block";
		document.getElementById(id+"Off").style.display = "none";
		document.getElementById(id+"On").style.display = "inline";
	}
}
</script>
</head>
<body>
<h1>An Error Occurred:</h1>
<div style="border: 1px solid #900;" class="grayBox" id="error">java.lang.StackOverflowError<br
/><br />viewId=/test/selectManyListbox/selectManyListbox-value.xhtml<br />location=/work/opensource-projects/tobago-trunk/tobago-example/tobago-example-test/target/tobago-example-test/test/selectManyListbox/selectManyListbox-value.xhtml<br
/>phaseId=RENDER_RESPONSE(6)<br /><br />Caused by:<br />java.lang.StackOverflowError<br
/> at org.eclipse.jetty.server.session.MemSession.doGet(MemSession.java:143)</div>
<h2><a onclick="toggle('trace'); return false;" href="#"><span id="traceOff">+</span><span
style="display: none;" id="traceOn">-</span> Stack Trace</a></h2>
<div class="grayBox" id="trace"><pre><code>java.lang.StackOverflowError
	at org.eclipse.jetty.server.session.MemSession.doGet(MemSession.java:143)
	at org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:452)
	at org.apache.myfaces.context.servlet.SessionMap.getAttribute(SessionMap.java:50)
	at org.apache.myfaces.util.AbstractThreadSafeAttributeMap.containsKey(AbstractThreadSafeAttributeMap.java:58)
	at org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.getValue(ManagedBeanResolver.java:211)
	at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:66)
	at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:179)
	at org.apache.el.parser.AstIdentifier.getValue(AstIdentifier.java:80)
	at org.apache.el.parser.AstValue.getTarget(AstValue.java:68)
	at org.apache.el.parser.AstValue.getType(AstValue.java:56)
	at org.apache.el.ValueExpressionImpl.getType(ValueExpressionImpl.java:171)
	at org.apache.myfaces.view.facelets.el.ContextAwareTagValueExpression.getType(ContextAwareTagValueExpression.java:73)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:161)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:123)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:103)
	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
	at org.apache.myfaces.tobago.util.ComponentUtils.getConvertedValue(ComponentUtils.java:1007)
	at org.apache.myfaces.tobago.internal.component.AbstractUISelectItem.getItemValue(AbstractUISelectItem.java:51)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase$SelectItemsIterator.hasNext(SelectManyRendererBase.java:558)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getSelectItemsValueConverter(SelectManyRendererBase.java:415)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:199)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:123)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:103)
	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
	at org.apache.myfaces.tobago.util.ComponentUtils.getConvertedValue(ComponentUtils.java:1007)
{noformat}


was (Author: deki):
Reopening because of test failure:
{noformat}
testPageConsistency[\/test\/selectManyListbox\/selectManyListbox-value_xhtml](org.apache.myfaces.tobago.example.test.AutomaticSeleniumTest)
 Time elapsed: 1.124 sec  <<< FAILURE!
java.lang.AssertionError: error on server
Page URL: http://localhost:8080/faces/test/selectManyListbox/selectManyListbox-value.xhtml

---------------------------------------------------------------------------------------------------
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
-->
<html xmlns="http://www.w3.org/1999/xhtml"><head>
<meta content="text/html; charset=iso-8859-1" http-equiv="Content-Type" />
<title>Error - java.lang.StackOverflowError</title>
<style type="text/css">
body, div, span, td, th, caption { font-family: 'Trebuchet MS', Verdana, Arial, Sans-Serif;
font-size: small; }
ul, li, pre { padding: 0; margin: 0; }
h1 { color: #900; }
h2, h2 span { font-size: large; color: #339; }
h2 a { text-decoration: none; color: #339; }
.grayBox { padding: 8px; margin: 10px 0; border: 1px solid #CCC; background-color: #f9f9f9;
 }
#error { color: #900; font-weight: bold; font-size: medium; }
#trace, #tree, #vars { display: none; }
code { font-size: medium; }
#tree dl { color: #006; }
#tree dd { margin-top: 2px; margin-bottom: 2px; }
#tree dt { border: 1px solid #DDD; padding: 4px; border-left: 2px solid #666; font-family:
"Courier New", Courier, mono; font-size: small; }
.uicText { color: #999;  }
.highlightComponent { color: #FFFFFF; background-color: #FF0000;  }
table { border: 1px solid #CCC; border-collapse: collapse; border-spacing: 0px; width: 100%;
text-align: left; }
td { border: 1px solid #CCC; }
thead tr th { padding: 2px; color: #030; background-color: #F9F9F9; }
tbody tr td { padding: 10px 6px; }
table caption { text-align: left; padding: 10px 0; font-size: large; }
</style>
<style media="print" type="text/css">
#trace, #tree, #vars { display: block; }
</style>
<script type="text/javascript" language="javascript">
function toggle(id) {
	var style = document.getElementById(id).style;
	if ("block" == style.display) {
		style.display = "none";
		document.getElementById(id+"Off").style.display = "inline";
		document.getElementById(id+"On").style.display = "none";
	} else {
		style.display = "block";
		document.getElementById(id+"Off").style.display = "none";
		document.getElementById(id+"On").style.display = "inline";
	}
}
</script>
</head>
<body>
<h1>An Error Occurred:</h1>
<div style="border: 1px solid #900;" class="grayBox" id="error">java.lang.StackOverflowError<br
/><br />viewId=/test/selectManyListbox/selectManyListbox-value.xhtml<br />location=/work/opensource-projects/tobago-trunk/tobago-example/tobago-example-test/target/tobago-example-test/test/selectManyListbox/selectManyListbox-value.xhtml<br
/>phaseId=RENDER_RESPONSE(6)<br /><br />Caused by:<br />java.lang.StackOverflowError<br
/> at org.eclipse.jetty.server.session.MemSession.doGet(MemSession.java:143)</div>
<h2><a onclick="toggle('trace'); return false;" href="#"><span id="traceOff">+</span><span
style="display: none;" id="traceOn">-</span> Stack Trace</a></h2>
<div class="grayBox" id="trace"><pre><code>java.lang.StackOverflowError
	at org.eclipse.jetty.server.session.MemSession.doGet(MemSession.java:143)
	at org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:452)
	at org.apache.myfaces.context.servlet.SessionMap.getAttribute(SessionMap.java:50)
	at org.apache.myfaces.util.AbstractThreadSafeAttributeMap.containsKey(AbstractThreadSafeAttributeMap.java:58)
	at org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.getValue(ManagedBeanResolver.java:211)
	at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:66)
	at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:179)
	at org.apache.el.parser.AstIdentifier.getValue(AstIdentifier.java:80)
	at org.apache.el.parser.AstValue.getTarget(AstValue.java:68)
	at org.apache.el.parser.AstValue.getType(AstValue.java:56)
	at org.apache.el.ValueExpressionImpl.getType(ValueExpressionImpl.java:171)
	at org.apache.myfaces.view.facelets.el.ContextAwareTagValueExpression.getType(ContextAwareTagValueExpression.java:73)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:161)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:123)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:103)
	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
	at org.apache.myfaces.tobago.util.ComponentUtils.getConvertedValue(ComponentUtils.java:1007)
	at org.apache.myfaces.tobago.internal.component.AbstractUISelectItem.getItemValue(AbstractUISelectItem.java:51)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase$SelectItemsIterator.hasNext(SelectManyRendererBase.java:558)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getSelectItemsValueConverter(SelectManyRendererBase.java:415)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:199)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:123)
	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:103)
	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
	at org.apache.myfaces.tobago.util.ComponentUtils.getConvertedValue(ComponentUtils.java:1007)

> SelectManyRendererBase should support Collection
> ------------------------------------------------
>
>                 Key: TOBAGO-1453
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1453
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.7
>            Reporter: Dennis Kieselhorst
>            Assignee: Volker Weber
>             Fix For: 3.0.0-alpha-1, 2.0.8
>
>
> Currently an IllegalArgumentException is thrown when trying to use selectMany with Collection.
> There is a code comment that UISelectMany expects List but this is no longer valid: https://docs.oracle.com/javaee/6/api/javax/faces/component/UISelectMany.html
> {noformat}
> Caused by: java.lang.IllegalArgumentException: ValueBinding for UISelectMany must be
of type List or Array
> 	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:182)
> 	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:88)
> 	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
> 	at javax.faces.component.UISelectMany.getConvertedValue(UISelectMany.java:388)
> 	at javax.faces.component.UIInput.validate(UIInput.java:598)
> 	at javax.faces.component.UIInput.processValidators(UIInput.java:274)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIBox.processValidators(AbstractUIBox.java:38)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIForm.processValidators(AbstractUIForm.java:83)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIPage.processValidators(AbstractUIPage.java:214)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at javax.faces.component.UIViewRoot._processValidatorsDefault(UIViewRoot.java:1697)
> 	at javax.faces.component.UIViewRoot.access$600(UIViewRoot.java:77)
> 	at javax.faces.component.UIViewRoot$ProcessValidatorPhaseProcessor.process(UIViewRoot.java:1804)
> 	at javax.faces.component.UIViewRoot._process(UIViewRoot.java:1653)
> 	at javax.faces.component.UIViewRoot.processValidators(UIViewRoot.java:909)
> 	at org.apache.myfaces.lifecycle.ProcessValidationsExecutor.execute(ProcessValidationsExecutor.java:38)
> 	at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:196)
> 	at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:143)
> 	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:198)
> 	... 63 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message