myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kito Mann <kito.m...@virtua.com>
Subject Re: Recent changes to SerializedViewCollection
Date Tue, 24 Mar 2015 14:44:15 GMT
Thanks, Leonardo. Totally missed that issue in JIRA.

I was thinking we need to use an LRU data structure. Just removing the key
and re-adding it is much simpler :-).

___

Kito D. Mann | @kito99 | Author, JSF in Action
Virtua, Inc. | http://www.virtua.com | JSF/Java EE training and consulting
http://www.JSFCentral.com | @jsfcentral
+1 203-998-0403

* Listen to the Enterprise Java Newscast: *http://
<http://blogs.jsfcentral.com/JSFNewscast/>enterprisejavanews.com
<http://ww.enterprisejavanews.com>*
* JSFCentral Interviews Podcast:
http://www.jsfcentral.com/resources/jsfcentralpodcasts/
* Sign up for the JSFCentral Newsletter: http://oi.vresp.com/?fid=ac048d0e17

On Mon, Mar 23, 2015 at 7:05 PM, Leonardo Uribe <lu4242@gmail.com> wrote:

> Hi Kito
>
> Checking the lists of issues, I think is this one:
>
> https://issues.apache.org/jira/browse/MYFACES-3886
> SerializedViewCollection does not update it's _keys list when
> _serializedViews contains key
>
> It was fixed on 2.2.4. In 2.2.x branch we did some improvements to
> align state saving algorithm with the client window API.
>
> regards,
>
> Leonardo Uribe
>
> 2015-03-23 15:59 GMT-05:00 Kito Mann <kito.mann@virtua.com>:
> > Hello everyone,
> >
> > One of my clients has been having an issue where MyFaces (2.2.3) is
> throwing
> > a ViewExpiredException if you have a scenario where you have a primary
> view
> > with a DataTable and the user repeatedly selects a record (which issues
> an
> > Ajax request) launches a popup window (with pure JS using window.open),
> and
> > closes the popup window. The problem was that SerializedViewCollection
> > wasn't taking into account how recently a view had been accessed before
> > allowing it to be expired. So even if the user just clicked on the
> primary
> > view 1 minute ago, the algorithm would still remove the primary view
> even if
> > it had slots filled with for popup windows that were accessed several
> > minutes ago.
> >
> > This problem appears to be fixed in 2.2.7. I suspect it might have been
> > fixed with MYFACES-3938 or MYFACES-3936. From looking at the code, I'm
> not
> > quite sure how though. Can someone shed some light?
> > ___
> >
> > Kito D. Mann | @kito99 | Author, JSF in Action
> > Virtua, Inc. | http://www.virtua.com | JSF/Java EE training and
> consulting
> > http://www.JSFCentral.com | @jsfcentral
> > +1 203-998-0403
> >
> > * Listen to the Enterprise Java Newscast: http://enterprisejavanews.com
> > * JSFCentral Interviews Podcast:
> > http://www.jsfcentral.com/resources/jsfcentralpodcasts/
> > * Sign up for the JSFCentral Newsletter:
> http://oi.vresp.com/?fid=ac048d0e17
>

Mime
View raw message