myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3936) Flash object requires cleanup strategy when client window feature is used
Date Fri, 31 Oct 2014 23:33:33 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192743#comment-14192743
] 

Leonardo Uribe commented on MYFACES-3936:
-----------------------------------------

Another fix to do is add a separtor char in:

String fullToken = FLASH_SESSION_MAP_SUBKEY_PREFIX + SEPARATOR_CHAR + token + SEPARATOR_CHAR;

to avoid mix the token with the key that is used on the map.

> Flash object requires cleanup strategy when client window feature is used
> -------------------------------------------------------------------------
>
>                 Key: MYFACES-3936
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3936
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-344
>    Affects Versions: 2.2.5
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>
> In 2.2.x a change was done to Flash object, so now it uses the client window id and store
the token into session instead use a cookie like it was done in 2.1.x/2.0.x
> The problem is there is no cleanup strategy in place. So if you create n client window
ids, there are n tokens in session and the session will only be cleaned  up when the session
is invalidated.
> The solution is use a LRU map to hold the tokens, so when a client window / token is
discarded, the objects stored in Flash scope associated to that couple could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message