myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand V Nath (JIRA)" <>
Subject [jira] [Commented] (TRINIDAD-2510) make SkinTestCase more extendable
Date Tue, 07 Oct 2014 05:35:33 GMT


Anand V Nath commented on TRINIDAD-2510:

I definitely considered this. Looks like the test case wants to provide a way to have the
tests decide how StyleSheetDocument is obtained.

So they provided a protected method

   * Returns the StyleSheetDocument for the specified test skin.
  protected StyleSheetDocument getSkinDocument(TestSkin testSkin)

And then that was invoked from 

> make SkinTestCase more extendable
> ---------------------------------
>                 Key: TRINIDAD-2510
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions: 2.1.0-core
>            Reporter: Anand V Nath
>            Priority: Minor
>         Attachments: jira-2510-modified.patch, jira-2510.patch
> SkinTestCase which is part of trinidad-impl/test, works with TestSkin enum which does
not offer flexibility. The change proposed is to add an overloaded method for visiting skins
where the skin resource path can be passed as a String. This will enable test cases extending
SkinTestCase to work with any skin of their choice.
> The proposed change is to add this method in SkinTestCase:
>   /**
>    * Performs a visit of all style sheet nodes in the specified test
>    * skin. This overloaded method is useful in extending SkinTestCase to
>    * create more test cases since TestSkin does not provide all the skins
>    * that test needs.
>    */
>   protected final void visitStyleSheets(String skinResourcePath, StyleSheetVisitor visitor)
>   {
>     StyleSheetDocument document = SkinTestUtils.parseSkin(skinResourcePath);
>     StyleSheetVisitUtils.visitStyleSheets(document.getStyleSheetsAsCollection(), visitor);
>   }

This message was sent by Atlassian JIRA

View raw message