myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Schwartz (JIRA)" <>
Subject [jira] [Updated] (TRINIDAD-2499) ChangeManager provides incorrect document location for dynamic components
Date Thu, 14 Aug 2014 13:48:12 GMT


Andy Schwartz updated TRINIDAD-2499:

       Resolution: Fixed
    Fix Version/s: 2.1.1-core
         Assignee: Andy Schwartz
           Status: Resolved  (was: Patch Available)

Fixed in r1617943.  Thanks Prakash!

> ChangeManager provides incorrect document location for dynamic components
> -------------------------------------------------------------------------
>                 Key: TRINIDAD-2499
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Archetype
>    Affects Versions: 2.1.0-core
>            Reporter: Prakash Udupa
>            Assignee: Andy Schwartz
>             Fix For: 2.1.1-core
>         Attachments: TRINIDAD-2499.patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> In TRINIDAD-2397, enhancement was provided to obtain the document location of components
are are dynamically added. There is a bug in this code that in some cases the location is
not provided correctly, as explained in the following example:
> Consider this page structure:
> <jsp:root>
>   <foo:three>
>     <foo:insertingComponent> <= Step #2: This subtree is inserted from fragment2.jsff
>       <jsp:root>
>         <foo:dynamicLayout>
>           <foo:two> <= Step #1: defined in fargment1.jsff
>             <foo:one> <= Customization target, this inserted component is defined
in fragment1.jsff
> In this example, the search for location is expected to stop at step #1 and location
returned as 'fragment1.jsff', instead the look up extends until step #2 and returns incorrect
location 'fragment2.jsff'.
> This causes the wrong document being searched for the customization target here, customization
failed therefore.
> The bug is in org.apache.myfaces.trinidad.util.ComponentUtils.getDocumentLocationForComponent()
> Will provide a fix patch soon.

This message was sent by Atlassian JIRA

View raw message