myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Updated] (MYFACES-3886) SerializedViewCollection does not update it's _keys list when _serializedViews contains key
Date Mon, 12 May 2014 14:54:16 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe updated MYFACES-3886:
------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have checked the solution and it is ok, I just committed a small modification in the removal,
but the result is the same. 

The test cases does not show any other problem, the precedence remains without changes and
the algorithm itself does not require anything else.

Thanks to Adam Balazs for provide this patch. 

> SerializedViewCollection does not update it's _keys list when _serializedViews contains
key
> -------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3886
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3886
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.2.2
>         Environment: PrimeFaces 4.0.12.
>            Reporter: Adam Balazs
>            Assignee: Leonardo Uribe
>             Fix For: 2.2.4
>
>         Attachments: SerializedViewCollection.java.patch
>
>
> When I use DialogFramework (of PrimeFaces), it's adds a new view to the session every
time. The problem is that when I post an AJAX request to the original view, the _keys list
is not updated, only the view get updated in the _serializedViews map.
> After I reach the limit defined with the org.apache.myfaces.NUMBER_OF_VIEWS_IN_SESSION
context-param, MyFaces gets the first element in the _keys list (which is the container view)
- assuming that this is the oldest view in the session - and remove the corresponding view
from the _serializedViews map by the key. But clearly it is not, as I already posted some
AJAX requests to it.
> I think the optimal behavior would be the following: when a view gets an ajax request
the code should remove the the key from the _keys list and than add it as a last element.
> The related class is org.apache.myfaces.application.viewstate.SerializedViewCollection
at the if condition started at line 87.
> My question is if it is an intended behavior or if it's a bug.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message