Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3B5110149 for ; Tue, 28 Jan 2014 19:34:17 +0000 (UTC) Received: (qmail 50728 invoked by uid 500); 28 Jan 2014 19:34:16 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 50659 invoked by uid 500); 28 Jan 2014 19:34:16 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 50652 invoked by uid 99); 28 Jan 2014 19:34:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 19:34:15 +0000 X-ASF-Spam-Status: No, hits=0.2 required=5.0 tests=FSL_NEW_HELO_USER,HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of prakash.udupa@oracle.com designates 156.151.31.81 as permitted sender) Received: from [156.151.31.81] (HELO userp1040.oracle.com) (156.151.31.81) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 19:34:06 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s0SJXh1U027999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Jan 2014 19:33:44 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s0SJXhBn004135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 28 Jan 2014 19:33:43 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s0SJXh1M001075 for ; Tue, 28 Jan 2014 19:33:43 GMT Received: from [10.154.191.26] (/10.154.191.26) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Jan 2014 11:33:42 -0800 Message-ID: <52E8060F.7050706@oracle.com> Date: Tue, 28 Jan 2014 13:33:35 -0600 From: Prakash Udupa Organization: Oracle Corporation User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20131118 Thunderbird/17.0.11 MIME-Version: 1.0 To: dev@myfaces.apache.org Subject: [Commit Request] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation References: In-Reply-To: Content-Type: multipart/alternative; boundary="------------060304050809000608050102" X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Virus-Checked: Checked by ClamAV on apache.org This is a multi-part message in MIME format. --------------060304050809000608050102 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I uploaded "TRINIDAD-2448_over_trunk.patch", this is the patch file over Trinidad trunk for this issue. One of the developers with write permission, please commit this patch. https://issues.apache.org/jira/browse/TRINIDAD-2448 Thanks, Prakash -------- Original Message -------- Subject: [jira] [Updated] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation Date: Fri, 24 Jan 2014 01:07:38 +0000 (UTC) From: Prakash Udupa (JIRA) Reply-To: MyFaces Development To: dev@myfaces.apache.org [https://issues.apache.org/jira/browse/TRINIDAD-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prakash Udupa updated TRINIDAD-2448: ------------------------------------ Status: Patch Available (was: Open) > Optimize ChangeManager.createDocumentChange() implementation > ------------------------------------------------------------ > > Key: TRINIDAD-2448 > URL:https://issues.apache.org/jira/browse/TRINIDAD-2448 > Project: MyFaces Trinidad > Issue Type: Improvement > Affects Versions: 2.1.0-core > Reporter: Prakash Udupa > Attachments: TRINIDAD-2448_over_trunk.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange( ComponentChange change) does not account for fact that the supplied ComponentChange implementation can also be implementing DocumentChange. Improvement is to do this check first, type cast the supplied component to DocumentChange and return. > There are several ComponentChange implementations in Trinidad that actually also implement DocumentChange, so this is common usecase. > Currently clients need to do this check outside of this call, which can be moved in here. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------060304050809000608050102 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi,

I uploaded "TRINIDAD-2448_over_trunk.patch", this is the patch file over Trinidad trunk for this issue. One of the developers with write permission, please commit this patch.
https://issues.apache.org/jira/browse/TRINIDAD-2448

Thanks,
Prakash


-------- Original Message --------
Subject: [jira] [Updated] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date: Fri, 24 Jan 2014 01:07:38 +0000 (UTC)
From: Prakash Udupa (JIRA) <dev@myfaces.apache.org>
Reply-To: MyFaces Development <dev@myfaces.apache.org>
To: dev@myfaces.apache.org 


     [ https://issues.apache.org/jira/browse/TRINIDAD-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prakash Udupa updated TRINIDAD-2448:
------------------------------------

    Status: Patch Available  (was: Open)

> Optimize ChangeManager.createDocumentChange() implementation
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-2448
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2448
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>    Affects Versions: 2.1.0-core
>            Reporter: Prakash Udupa
>         Attachments: TRINIDAD-2448_over_trunk.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange( ComponentChange change) does not account for fact that the supplied ComponentChange implementation can also be implementing DocumentChange. Improvement is to do this check first, type cast the supplied component to DocumentChange and return. 
> There are several ComponentChange implementations in Trinidad that actually also implement DocumentChange, so this is common usecase.
> Currently clients need to do this check outside of this call, which can be moved in here.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


--------------060304050809000608050102--