myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <>
Subject [jira] [Updated] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date Tue, 28 Jan 2014 22:27:37 GMT


Jeanne Waldman updated TRINIDAD-2448:

       Resolution: Fixed
    Fix Version/s: 2.1.1-core
         Assignee: Jeanne Waldman
           Status: Resolved  (was: Patch Available)

patched trunk

> Optimize ChangeManager.createDocumentChange() implementation
> ------------------------------------------------------------
>                 Key: TRINIDAD-2448
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>    Affects Versions: 2.1.0-core
>            Reporter: Prakash Udupa
>            Assignee: Jeanne Waldman
>             Fix For: 2.1.1-core
>         Attachments: TRINIDAD-2448_over_trunk.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange(
ComponentChange change) does not account for fact that the supplied ComponentChange implementation
can also be implementing DocumentChange. Improvement is to do this check first, type cast
the supplied component to DocumentChange and return. 
> There are several ComponentChange implementations in Trinidad that actually also implement
DocumentChange, so this is common usecase.
> Currently clients need to do this check outside of this call, which can be moved in here.

This message was sent by Atlassian JIRA

View raw message