myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date Tue, 28 Jan 2014 22:27:35 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884791#comment-13884791
] 

Jeanne Waldman commented on TRINIDAD-2448:
------------------------------------------

Sending content: C:\Trinidad\trinidad-api\src\main\java\org\apache\myfaces\trinidad\change\ChangeManager.java
 
Sending content: C:\Trinidad\trinidad-api\src\main\java\org\apache\myfaces\trinidad\change\BaseChangeManager.java
 
Completed: At revision: 1562288  


> Optimize ChangeManager.createDocumentChange() implementation
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-2448
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2448
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>    Affects Versions: 2.1.0-core
>            Reporter: Prakash Udupa
>             Fix For: 2.1.1-core
>
>         Attachments: TRINIDAD-2448_over_trunk.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange(
ComponentChange change) does not account for fact that the supplied ComponentChange implementation
can also be implementing DocumentChange. Improvement is to do this check first, type cast
the supplied component to DocumentChange and return. 
> There are several ComponentChange implementations in Trinidad that actually also implement
DocumentChange, so this is common usecase.
> Currently clients need to do this check outside of this call, which can be moved in here.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message