myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prakash Udupa (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Created] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date Fri, 24 Jan 2014 01:05:39 GMT
Prakash Udupa created TRINIDAD-2448:
---------------------------------------

             Summary: Optimize ChangeManager.createDocumentChange() implementation
                 Key: TRINIDAD-2448
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2448
             Project: MyFaces Trinidad
          Issue Type: Improvement
    Affects Versions: 2.1.0-core
            Reporter: Prakash Udupa



Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange(
ComponentChange change) does not account for fact that the supplied ComponentChange implementation
can also be implementing DocumentChange. Improvement is to do this check first, type cast
the supplied component to DocumentChange and return. 

There are several ComponentChange implementations in Trinidad that actually also implement
DocumentChange, so this is common usecase.

Currently clients need to do this check outside of this call, which can be moved in here.




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message