myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prakash Udupa <>
Subject [Commit Request] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date Tue, 28 Jan 2014 19:33:35 GMT

I uploaded "TRINIDAD-2448_over_trunk.patch", this is the patch file over Trinidad trunk for
this issue. One of the 
developers with write permission, please commit this patch.


-------- Original Message --------
Subject: 	[jira] [Updated] (TRINIDAD-2448) Optimize ChangeManager.createDocumentChange() implementation
Date: 	Fri, 24 Jan 2014 01:07:38 +0000 (UTC)
From: 	Prakash Udupa (JIRA) <>
Reply-To: 	MyFaces Development <>


Prakash Udupa updated TRINIDAD-2448:

     Status: Patch Available  (was: Open)

> Optimize ChangeManager.createDocumentChange() implementation
> ------------------------------------------------------------
>                 Key: TRINIDAD-2448
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>    Affects Versions: 2.1.0-core
>            Reporter: Prakash Udupa
>         Attachments: TRINIDAD-2448_over_trunk.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange(
ComponentChange change) does not account for fact that the supplied ComponentChange implementation
can also be implementing DocumentChange. Improvement is to do this check first, type cast
the supplied component to DocumentChange and return.
> There are several ComponentChange implementations in Trinidad that actually also implement
DocumentChange, so this is common usecase.
> Currently clients need to do this check outside of this call, which can be moved in here.

This message was sent by Atlassian JIRA

View raw message