Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8221E10201 for ; Tue, 5 Nov 2013 16:24:23 +0000 (UTC) Received: (qmail 74930 invoked by uid 500); 5 Nov 2013 16:24:23 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 74595 invoked by uid 500); 5 Nov 2013 16:24:20 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 74588 invoked by uid 99); 5 Nov 2013 16:24:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Nov 2013 16:24:19 +0000 Date: Tue, 5 Nov 2013 16:24:19 +0000 (UTC) From: "Mike Kienenberger (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MYFACES-3804) Use the same key in server side state saving for ajax requests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MYFACES-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814014#comment-13814014 ] Mike Kienenberger commented on MYFACES-3804: -------------------------------------------- Dora, We need to move discussion to the developer mailing list, and reserve the JIRA for resolving issues. There are a number of reasons why the JIRA issue is not the best place for discussion, which I wrote about here: http://mail-archives.apache.org/mod_mbox/myfaces-dev/201311.mbox/%3CCAM1yOjZHhSRwrAQ2Va_Em0yAcPD9mA9D-7daCG7z-eHfr%3DZ0-g%40mail.gmail.com%3E I'm sorry that I didn't speak up a while back when I first noticed it happening, but we need to resume using the developer mailing list for its intended purpose. > Use the same key in server side state saving for ajax requests > -------------------------------------------------------------- > > Key: MYFACES-3804 > URL: https://issues.apache.org/jira/browse/MYFACES-3804 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-344 > Reporter: Leonardo Uribe > Attachments: ajaxviewkeytest.patch, ajaxviewkeytest2.patch, ajaxviewsamekey.patch, ajaxviewsamekey2.patch, ajaxviewsamekey3.patch > > > The current code for server side state saving creates one key per request to store the view state. This is ok, but it is not necessary for ajax requests. > The reason why is not necessary is because you can never go back to a page when using ajax. If you are on page A and the current request is an ajax request and it returns to the same page and the view is the same that the one that has been restored, the key or the token sent does not need to change, what changes is the internal state of the view. From the client side the page is the same. We can take advantage of this fact and just update the state stored in SerializedViewCollection for the view. > The challenge here is detect when this strategy is applicable. For example, what happen if there is an ajax redirect? It looks is a good idea for implement in 2.2, because it avoids to store unnecessary information into session and optimize the use of each view slot. -- This message was sent by Atlassian JIRA (v6.1#6144)