Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56ACE109F9 for ; Wed, 6 Nov 2013 21:44:02 +0000 (UTC) Received: (qmail 63792 invoked by uid 500); 6 Nov 2013 21:44:01 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 63761 invoked by uid 500); 6 Nov 2013 21:44:01 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 63754 invoked by uid 99); 6 Nov 2013 21:44:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 21:44:01 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS,UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of blake.sullivan@oracle.com designates 141.146.126.69 as permitted sender) Received: from [141.146.126.69] (HELO aserp1040.oracle.com) (141.146.126.69) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 21:43:54 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rA6LhWPB013642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Nov 2013 21:43:33 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA6LhV09028144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Nov 2013 21:43:32 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA6LhVt1009961; Wed, 6 Nov 2013 21:43:31 GMT Received: from dhcp-2op11-2op12-west-130-35-103-20.usdhcp.oraclecorp.com (/130.35.103.20) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Nov 2013 13:43:30 -0800 Subject: Re: [VOTE] Release of Trinidad Maven Plugins 2.0.8 Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: multipart/alternative; boundary="Apple-Mail=_DEB62116-18E2-4439-AD68-CEEDAD1A26A2" From: Blake Sullivan In-Reply-To: Date: Wed, 6 Nov 2013 13:43:30 -0800 Cc: "Scott O'Bryan" Message-Id: <9D35335A-E3CB-44ED-9283-8403E9544079@oracle.com> References: To: "MyFaces Development" X-Mailer: Apple Mail (2.1283) X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail=_DEB62116-18E2-4439-AD68-CEEDAD1A26A2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 +1 for me as well. Presumably we won't run into this problem later = since the tags are generated in impl and Enums showing up in their api = should be in the api package. We could have this problem if we added = enum support to components, but the component generation has access to = the component metadata, which knows that this is an enum case. -- Blake Sullivan On Nov 6, 2013, at 1:35 PM, Andy Schwartz wrote: > Hey Scott - >=20 > Great, thanks for tracking this down. +1 for me then. >=20 > Andy >=20 >=20 >=20 > On Wed, Nov 6, 2013 at 12:55 PM, Scott O'Bryan = wrote: > I'm changing my vote to +1. I was able to fix this issue in the = trinidad poms by adding: >=20 > > > org.apache.myfaces.trinidad > trinidad-api > ${project.version} > > >=20 > To the maven-faces plugin definition in trinidad-impl. So I'll = handle the ticket under trinidad and make sure its part of the next = release. The key was found in the maven class loading guide: >=20 > http://maven.apache.org/guides/mini/guide-maven-classloading.html >=20 > I noticed that the error was being issued in the impl package which = should have had access to the api. But the dependencies are only = explicitly available to the javacc plugin or can be referenced manually = by the mojo. Our mojo doesn't handle dependencies, so the configuration = is necessary. Might be nice to add it at some point though. >=20 > Andy, does this work for you? >=20 > --=20 > Scott O'Bryan >=20 > On November 6, 2013 at 8:32:00 AM, Scott O'Bryan (darkarena@gmail.com) = wrote: >=20 >> Andy,=20 >>=20 >> Yeah, I was seeing this too. I was trying to track this as part of = my work for the next Trinidad release, but I think your right. This may = be handled better in the plugin. At the very least we should evaluate = it. What's happening here is a new check was added to test if a class = for an attribute happens to be an enumeration. In the case where we get = the error, DateListProvider hasn't been built yet since the plugins = generate the source BEFORE the plugins are built. >>=20 >> I'm going to generate a JIRA ticket and I for one think we need to = fix this issue before releasing the plugins. As such. my vote is a -1 = pending this issue. >> --=20 >> Scott O'Bryan >>=20 >> On November 6, 2013 at 7:42:03 AM, Andy Schwartz = (andy.g.schwartz@gmail.com) wrote: >>=20 >>> Hey Scott - >>>=20 >>> I attempted to do a clean Trinidad build against the new plugins. I = happened to notice this exception during the build: >>>=20 >>> > [INFO] --- maven-faces-plugin:2.0.8:generate-jsp-taglibs (default) = @ trinidad-impl --- >>> > [INFO] ClassNotFound error resolving type = org.apache.myfaces.trinidad.model.DateListProvider >>> > java.lang.ClassNotFoundException: = org.apache.myfaces.trinidad.model.DateListProvider >>> > at = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfF= irstStrategy.java:50) >>> > at = org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java= :244) >>> > at = org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java= :230) >>> > at java.lang.Class.forName0(Native Method) >>> > at java.lang.Class.forName(Class.java:169) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.util.ClassLoaderUtils.loadCl= ass(ClassLoaderUtils.java:86) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.util.ClassLoaderUtils.loadCl= ass(ClassLoaderUtils.java:47) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractTag= Generator.resolveType(AbstractTagGenerator.java:247) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.TrinidadVal= idatorTagGenerator.writeSetProperty(TrinidadValidatorTagGenerator.java:115= ) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractVal= idatorTagGenerator.writeSetProperties(AbstractValidatorTagGenerator.java:1= 85) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractVal= idatorTagGenerator.generateTagHandler(AbstractValidatorTagGenerator.java:6= 2) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.GenerateJspTaglibsMojo._gene= rateTagHandlers(GenerateJspTaglibsMojo.java:794) >>> > at = org.apache.myfaces.trinidadbuild.plugin.faces.GenerateJspTaglibsMojo.execu= te(GenerateJspTaglibsMojo.java:104) >>> > at = org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuild= PluginManager.java:101) >>> > at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :209) >>> > at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :153) >>> > at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :145) >>> > at = org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Li= fecycleModuleBuilder.java:84) >>> > at = org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Li= fecycleModuleBuilder.java:59) >>> > at = org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(L= ifecycleStarter.java:183) >>> > at = org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStar= ter.java:161) >>> > at = org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319) >>> > at = org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) >>> > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) >>> > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) >>> > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) >>> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> > at = sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:= 39) >>> > at = sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm= pl.java:25) >>> > at java.lang.reflect.Method.invoke(Method.java:597) >>> > at = org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.= java:290) >>> > at = org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230= ) >>> > at = org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launche= r.java:409) >>> > at = org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) >>> > [INFO] Generated 145 JSP tag(s) >>>=20 >>> I have no idea whether this exception in new in 2.0.8. Is this = something that we should look at before rolling out the plugins release? >>>=20 >>> Andy >>>=20 >>>=20 >>>=20 >>> On Mon, Nov 4, 2013 at 4:29 PM, Scott O'Bryan = wrote: >>> I was running the tasks needed to release the Trinidad Maven Plugins = version 2.0.8 which is needed as a prerequisite to a Trinidad release. = I have compiled the Release Notes[1] for the 2.0.8 release. =20 >>>=20 >>> I have generated the tag [2] and have deployed the built artifacts = to nexus [3]. Lastly I have included a source archive [4]. I've done = preliminary testing and building, updated the plugins to comply with = checkstyle, and made sure the build passed rat:check. >>>=20 >>> Please take a look at the Trinidad Maven Plugins 2.0.8 release = artifacts now and vote. >>>=20 >>> Please note:=20 >>>=20 >>> This vote is "majority approval" with a minimum of three +1 votes = (see [5]).=20 >>>=20 >>> ------------------------------------------------=20 >>> [ ] +1 for community members who have reviewed the bits =20 >>> [ ] +0=20 >>> [ ] -1 for fatal flaws that should cause these bits not to be = released, and why..............=20 >>> ------------------------------------------------=20 >>>=20 >>> Thanks,=20 >>> Scott O'Bryan >>>=20 >>> [1] = https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=3D1231066= 1&version=3D12319290 >>> [2] = https://svn.apache.org/repos/asf/myfaces/trinidad-maven/tags/maven-plugin-= parent-2.0.8 >>> [3] = https://repository.apache.org/content/repositories/orgapachemyfaces-069 >>> [4] = https://repository.apache.org/content/repositories/orgapachemyfaces-069/or= g/apache/myfaces/trinidadbuild/maven-plugin-parent/2.0.8/maven-plugin-pare= nt-2.0.8-source-release.zip >>> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes >>>=20 >=20 --Apple-Mail=_DEB62116-18E2-4439-AD68-CEEDAD1A26A2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=iso-8859-1 +1 = for me as well.  Presumably we won't run into this problem later = since the tags are generated in impl and Enums showing up in their api = should be in the api package.  We could have this problem if we = added enum support to components, but the component generation has = access to the component metadata, which knows that this is an enum = case.

-- Blake Sullivan

On Nov = 6, 2013, at 1:35 PM, Andy Schwartz wrote:

Hey Scott -

Great, thanks for tracking = this down.  +1 for me = then.

Andy



On Wed, Nov 6, = 2013 at 12:55 PM, Scott O'Bryan <darkarena@gmail.com> wrote:
I'm changing my vote to +1.  I was able to fix this issue in the = trinidad poms by adding:

        = <dependencies>
      =     <dependency>
  =           = <groupId>org.apache.myfaces.trinidad</groupId>
            = <artifactId>trinidad-api</artifactId>
            = <version>${project.version}</version>
          =  </dependency>
        =  </dependencies>

To the maven-faces = plugin definition in trinidad-impl.  So  I'll handle the = ticket under trinidad and make sure its part of the next release. =  The key was found in the maven class loading guide:


I noticed that the error was being issued = in the impl package which should have had access to the api.  But = the dependencies are only explicitly available to the javacc plugin or = can be referenced manually by the mojo.  Our mojo doesn't handle = dependencies, so the configuration is necessary.  Might be nice to = add it at some point though.

Andy, does this work for you?

-- 
Scott O'Bryan

On November 6, 2013 at 8:32:00 AM, Scott O'Bryan = (darkarena@gmail.com) wrote:

=
Andy, 

Yeah, I was seeing this too.  I was trying to track this as part of my work for the next Trinidad release, but I think your right.  This may be handled better in the plugin.  At the very least we should evaluate it.  What's happening here is a new check was added to test if a class for an attribute happens to be an enumeration.  In the case where we get the error, DateListProvider hasn't been built yet since the plugins generate the source BEFORE the plugins are built.

I'm going to generate a JIRA ticket and I for one think we need to fix this issue before releasing the plugins.  As such. my vote is a -1 pending this issue.
-- 
Scott O'Bryan

On November 6, 2013 at 7:42:03 AM, Andy Schwartz (andy.g.schwartz@gmail.com) wrote:


I attempted to do a clean Trinidad build against the new plugins.  I happened to notice this exception during the build:

> [INFO] --- maven-faces-plugin:2.0.8:generate-jsp-taglibs (default) @ trinidad-impl ---
> [INFO] ClassNotFound error resolving type org.apache.myfaces.trinidad.model.DateListProvider
> java.lang.ClassNotFoundException: org.apache.myfaces.trinidad.model.DateListProvider
>     at = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfF= irstStrategy.java:50)
>     at = org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java= :244)
>     at = org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java= :230)
>     at java.lang.Class.forName0(Native Method)
>     at java.lang.Class.forName(Class.java:169)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.util.ClassLoaderUtils.loadCl= ass(ClassLoaderUtils.java:86)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.util.ClassLoaderUtils.loadCl= ass(ClassLoaderUtils.java:47)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractTag= Generator.resolveType(AbstractTagGenerator.java:247)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.TrinidadVal= idatorTagGenerator.writeSetProperty(TrinidadValidatorTagGenerator.java:115= )
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractVal= idatorTagGenerator.writeSetProperties(AbstractValidatorTagGenerator.java:1= 85)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.AbstractVal= idatorTagGenerator.generateTagHandler(AbstractValidatorTagGenerator.java:6= 2)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.GenerateJspTaglibsMojo._gene= rateTagHandlers(GenerateJspTaglibsMojo.java:794)
>     at = org.apache.myfaces.trinidadbuild.plugin.faces.GenerateJspTaglibsMojo.execu= te(GenerateJspTaglibsMojo.java:104)
>     at = org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuild= PluginManager.java:101)
>     at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :209)
>     at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :153)
>     at = org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java= :145)
>     at = org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Li= fecycleModuleBuilder.java:84)
>     at = org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Li= fecycleModuleBuilder.java:59)
>     at = org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(L= ifecycleStarter.java:183)
>     at = org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStar= ter.java:161)
>     at = org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
>     at = org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
<= div style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; font: normal normal normal 12px/normal Helvetica; "> >     at = org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at = sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:= 39)
>     at = sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm= pl.java:25)
>     at java.lang.reflect.Method.invoke(Method.java:597)
>     at = org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.= java:290)
>     at = org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230= )
>     at = org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launche= r.java:409)
>     at = org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)<= /span>
> [INFO] Generated 145 JSP tag(s)

I have no idea whether this exception in new in 2.0.8.  Is this something that we should look at before rolling out the plugins release?

Andy
On Mon, Nov 4, 2013 at 4:29 PM, Scott O'Bryan <darkarena@gmail.com> wrote:
I was running the tasks needed to release the Trinidad Maven Plugins version 2.0.8 which is needed as a prerequisite to a Trinidad release.  I have compiled the Release Notes[1] for the 2.0.8 release.  

I have generated the tag [2] and have deployed the built artifacts to nexus [3].  Lastly I have included a source archive [4].  I've done preliminary testing and building, updated the plugins to comply with checkstyle, and made sure the build passed rat:check.

Please take a look at the Trinidad Maven Plugins 2.0.8 release artifacts now and vote.

Please note: 

This vote is "majority approval" with a minimum of three +1 votes (see [5]). 

------------------------------------------= ------ 
[ ] +1 for community members who have reviewed the bits  
[ ] +0 
[ ] -1 for fatal flaws that should cause these bits not to be released, and why.............. 
------------------------------------------= ------ 

Thanks, 
  Scott O'Bryan


=

<= /div>

= --Apple-Mail=_DEB62116-18E2-4439-AD68-CEEDAD1A26A2--