Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Mon, 7 Oct 2013 08:56:42 +0000 (UTC)
From: "Gerhard Petracek (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <JIRA.12672535.1381079776337.24531.1381136202307@arcas>
In-Reply-To: <JIRA.12672535.1381079776337@arcas>
References: <JIRA.12672535.1381079776337@arcas>
Subject: [jira] [Resolved] (MYFACES-3798) protected-view handling is broken
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MYFACES-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerhard Petracek resolved MYFACES-3798.
---------------------------------------

    Resolution: Not A Problem

agreed. i had to check a 3rd party code + a test which showed the issue. however, the real issue is in the 3rd party code (a quite hidden and dirty reassignment of _protectedViewsSet via reflection).

> protected-view handling is broken
> ---------------------------------
>
>                 Key: MYFACES-3798
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3798
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-344
>    Affects Versions: 2.2.0
>            Reporter: Gerhard Petracek
>            Assignee: Leonardo Uribe
>
> the result of ViewHandlerImpl#getProtectedViewsUnmodifiable isn't spec. compliant.
> addProtectedView and removeProtectedView don't recreate _unmodifiableProtectedViewsSet. at the end of both we need:
> _unmodifiableProtectedViewsSet = Collections.unmodifiableSet(_protectedViewsSet);
> or we always return Collections.unmodifiableSet(_protectedViewsSet); in ViewHandlerImpl#getProtectedViewsUnmodifiable


--
This message was sent by Atlassian JIRA
(v6.1#6144)