Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B69F41026C for ; Thu, 17 Oct 2013 15:29:44 +0000 (UTC) Received: (qmail 79671 invoked by uid 500); 17 Oct 2013 15:29:43 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 79587 invoked by uid 500); 17 Oct 2013 15:29:43 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 79536 invoked by uid 99); 17 Oct 2013 15:29:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2013 15:29:42 +0000 Date: Thu, 17 Oct 2013 15:29:42 +0000 (UTC) From: "Leonardo Uribe (JIRA)" To: dev@myfaces.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MYFACES-3587) Not existing viewId will not be handled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MYFACES-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798007#comment-13798007 ] Leonardo Uribe commented on MYFACES-3587: ----------------------------------------- Added web config param org.apache.myfaces.STRICT_JSF_2_VIEW_NOT_FOUND and fixed case when org.apache.myfaces.SUPPORT_JSP_AND_FACES_EL=false (catch filenotfoundexception and throw 404 response, and if vdl is not found throw 404 response too) > Not existing viewId will not be handled > --------------------------------------- > > Key: MYFACES-3587 > URL: https://issues.apache.org/jira/browse/MYFACES-3587 > Project: MyFaces Core > Issue Type: Bug > Components: General > Affects Versions: 2.1.8 > Environment: Jetty/Tomcat, JUEL, CODI, ExtVal > Reporter: Thomas Andraschko > Assignee: Leonardo Uribe > Fix For: 2.1.13 > > > If i call a page, which does not exist, following exceptions occurs: Cannot reset buffer after response has been committed. > After digging deeper into this problem, i found out that getViewHandlerSupport()#calculateViewId returns null and the JspViewDeclarationLanguageStrategy will be used -> > Cannot reset buffer after response has been committed. > occurs. > I added a null check for the logicalViewId in RestoreViewExecutor#execute to call HttpServletResponse#sendError. > It does not work as expected because it just renders the errorPage and no redirect will be done. > Why there is not such null check? > Is it possible to add this check and redirect to the web.xml defined 404 or common error page? Or should it use the ErrorHandler? -- This message was sent by Atlassian JIRA (v6.1#6144)